-
Notifications
You must be signed in to change notification settings - Fork 1.9k
ML.FastTree nuget package doesn't work with packages.config #3626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks @eerhardt for filing and fixing :) |
The FastTree NuGet package is currently broken on .NET Framework when using packages.config because we are not copying the native files to the output folder. Fix dotnet#3626
The FastTree NuGet package is currently broken on .NET Framework when using packages.config because we are not copying the native files to the output folder. Fix dotnet#3626
The FastTree NuGet package is currently broken on .NET Framework when using packages.config because we are not copying the native files to the output folder. Fix #3626
The FastTree NuGet package is currently broken on .NET Framework when using packages.config because we are not copying the native files to the output folder. Fix #3626
I am using ML.Net.FastTree and i keep running into this issue even after re-installing the package : Any ideas on how to solve this issue? |
@alex-resdiary - could you give a little more information on your project? (If you could zip up your project and send it to me, that would be easiest. My email is in my github profile.) Are you targeting .NET Framework or .NET Core? Are you using |
I'm seeing the same problem. I'll send you a repro solution. The exception info: System.AggregateException This exception was originally thrown at this call stack: Inner Exception 1: |
Is the .dll in the output folder? |
Is the .dll in the output folder?
No. But if I copy
"F:\Repros\FatTreeNativeProblem\packages\Microsoft.ML.FastTree.1.7.0\runtimes\win-x86\native\FastTreeNative.dll"
to bin\Debug, I don't get the error. Shouldn't this be copied by NuGet when
I install Microsoft.ML.FastTree? I have to copy it manually. If I try to
add the above file as a reference, I get an error from Visual Studio. The
solution I emailed you demonstrates this. I also tried uninstalling and
reinstalling the FastTree package.
…On Thu, Jan 20, 2022 at 11:40 AM Eric Erhardt ***@***.***> wrote:
Is the .dll in the output folder?
—
Reply to this email directly, view it on GitHub
<#3626 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOW64JIXGJBKKDZWJSA5T3UXBQJZANCNFSM4HJQMOJQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
--
John Thompson
***@***.***
https://www.jtlanguage.com
1-909-283-4364 (home)
1-909-283-5642 (cell)
|
The issue with your project is that you are using packages.config and a ProjectReference from your "app" project to your "library" project. With packages.config, the NuGet dependencies aren't transitive, like they are with Alternatively, if you want to continue using packages.config, you need to install the Microsoft.ML.FastTree package in the "app"/ "exe" project. |
Thanks. Got it. I thought Visual Studio copied dependent DLLs, but I guess the FastTreeNative.dll is loaded dynamically, so VS didn't know about it. |
Try using Microsoft.ML.FastTree on .NET Framework using
packages.config
.You get an exception:
This is because we aren't copying the
FastTreeNative.dll
to the output folder.We should be including https://github.com/dotnet/machinelearning/blob/master/pkg/common/CommonPackage.props in the nuget package, and this would start working.
@shauheen @glebuk @TomFinley
The text was updated successfully, but these errors were encountered: