Skip to content

NormalizeMeanVariance uses Population Variance #6606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DavidMartinOnGitHub opened this issue Mar 22, 2023 · 1 comment · Fixed by #6885
Closed

NormalizeMeanVariance uses Population Variance #6606

DavidMartinOnGitHub opened this issue Mar 22, 2023 · 1 comment · Fixed by #6885
Labels
good first issue Good for newcomers P3 Doc bugs, questions, minor issues, etc. up-for-grabs A good issue to fix if you are trying to contribute to the project
Milestone
ML.NET Future

Comments

@DavidMartinOnGitHub
Copy link

[Enter feedback here]
It should probably be stated that this estimator uses the Population Variance not the Sample Variance. i.e. it does not apply Bessel's Correction.

Since we're dealing with a sample of data in our ML activities not the entire population, a Sample Variance would be more intuitive (for some).

The difference will not be significant on large data sets. But it would be good to be more explicit about the calculation method.

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
@ghost ghost added the untriaged New issue has not been triaged label Mar 22, 2023
@luisquintanilla luisquintanilla added P3 Doc bugs, questions, minor issues, etc. good first issue Good for newcomers up-for-grabs A good issue to fix if you are trying to contribute to the project labels Mar 29, 2023
@luisquintanilla luisquintanilla added this to the ML.NET Future milestone Mar 29, 2023
@ghost ghost removed the untriaged New issue has not been triaged label Mar 29, 2023
@luisquintanilla
Copy link
Contributor

Hi @DavidMartinOnGitHub

Thanks for raising this issue.

@tearlant tearlant mentioned this issue Nov 3, 2023
Closed
@tearlant tearlant mentioned this issue Nov 14, 2023
Merged
@ghost ghost added the in-pr label Nov 14, 2023
michaelgsharp added a commit that referenced this issue Dec 11, 2023
@tearlant @michaelgsharp
Issue #6606 - Add sample variance and standard deviation to Normalize…
eb9af18 
…MeanVariance (#6885)

* Add sample standard deviation flag

* Update NormalizeColumnDbl.cs

* Update NormalizeColumnSng.cs

---------

Co-authored-by: emeikleham <[email protected]>
Co-authored-by: Michael Sharp <[email protected]>
@ghost ghost removed the in-pr label Dec 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers P3 Doc bugs, questions, minor issues, etc. up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Milestone
ML.NET Future
2 participants
@DavidMartinOnGitHub @luisquintanilla