Skip to content

Forecasting model framework for time series. #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 3, 2019
Merged

Forecasting model framework for time series. #1900

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b10477a
Forecasting interface with a unit-test.
codemzs Dec 18, 2018
9348ba9
Comments.
codemzs Dec 18, 2018
a53d743
cleanup.
codemzs Dec 18, 2018
04e7193
cleanup.
codemzs Dec 18, 2018
b2319fd
Internalize forecasting model and expose bare minimum needed and merg…
codemzs May 29, 2019
feb85e5
PR feedback.
codemzs May 31, 2019
f57b2a3
PR feedback.
codemzs May 31, 2019
a34d8ea
PR feedback.
codemzs May 31, 2019
0d20e36
Comments.
codemzs May 31, 2019
c9811ed
Samples.
codemzs Jun 1, 2019
1394477
Samples.
codemzs Jun 1, 2019
a6fd250
Comments.
codemzs Jun 1, 2019
850bb00
Fix sample output.
codemzs Jun 1, 2019
273c0f8
clean up.
codemzs Jun 1, 2019
0d6feb4
clean up.
codemzs Jun 1, 2019
c435ef0
docs and cleanup.
codemzs Jun 3, 2019
9a1a840
typo in doc.
codemzs Jun 3, 2019
3afefde
PR feedback.
codemzs Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typo in doc.
  • Loading branch information
@codemzs
codemzs committed Jun 3, 2019
commit 9a1a840f297685b27a6580eb69605cc738c170e1
2 changes: 1 addition & 1 deletion src/Microsoft.ML.TimeSeries/AdaptiveSingularSpectrumSequenceModeler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public struct GrowthRatio
private Double _growth;

/// <summary>
/// Time span of growth ratio. Must be strictly positibe.
/// Time span of growth ratio. Must be strictly positive.
/// </summary>
public int TimeSpan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use an int here? Why not use a TimeSpan type, which avoids any confusion about what unit this int is? seconds? Minutes? days?

{
Expand Down