Remove legacy API test that already have coverage and refactor code. #2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abgoswam
reviewed
Jan 4, 2019
test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs
Outdated
Show resolved
Hide resolved
abgoswam
reviewed
Jan 4, 2019
test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/IrisPlantClassificationTests.cs
Outdated
Show resolved
Hide resolved
|
Could you add the SymSGD test directly in this PR? It would be good to check that we can regain the test coverage of microsoft.ml.hallearners.dll and have a final number on the impact of this PR. #Resolved |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted all tests under test/Microsoft.ML.Tests/Scenarios/PipelineApi and removed SentimentPredictionTests.cs from test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation because these tests already have equivalent tests that use new api under test/Microsoft.ML.Tests/Scenarios/Api/Estimators.
Verified the code coverage wasn't affected too much, its now at 68.94% vs 68.97% the difference is in the below dlls:
microsoft.ml.data.dll - 0.05%
microsoft.ml.entrypoints.dll - 0.18% (expected since legacy api calls into core entrypoints API)
microsoft.ml.fasttree.dll - 0.04%
microsoft.ml.hallearners.dll - 0.99% (This drop is coming from the removal of SymSGD test, will add one in another PR)
microsoft.ml.transforms.dll - 0.06%