Skip to content

Extract IDataView into its own assembly and NuGet package #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 25, 2019
Merged

Extract IDataView into its own assembly and NuGet package #2220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff443fc
Move IDataView files into new Microsoft.Data.DataView folder
eerhardt Jan 23, 2019
9508e39
Add Microsoft.Data.DataView assembly and NuGet package.
eerhardt Jan 24, 2019
6af15d8
Make ML.NET build on the new Microsoft.Data.DataView assembly.
eerhardt Jan 24, 2019
86a9ed2
Fix tests for the new Data assembly.
eerhardt Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Microsoft.ML.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,14 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "common", "common", "{A84717
pkg\common\DnnImageFeaturizer.props = pkg\common\DnnImageFeaturizer.props
EndProjectSection
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Data.DataView", "src\Microsoft.Data.DataView\Microsoft.Data.DataView.csproj", "{85D0CAFD-2FE8-496A-88C7-585D35B94243}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Microsoft.Data.DataView", "Microsoft.Data.DataView", "{31D38B21-102B-41C0-9E0A-2FE0BF68D123}"
ProjectSection(SolutionItems) = preProject
pkg\Microsoft.Data.DataView\Microsoft.Data.DataView.nupkgproj = pkg\Microsoft.Data.DataView\Microsoft.Data.DataView.nupkgproj
pkg\Microsoft.Data.DataView\Microsoft.Data.DataView.symbols.nupkgproj = pkg\Microsoft.Data.DataView\Microsoft.Data.DataView.symbols.nupkgproj
EndProjectSection
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -894,6 +902,18 @@ Global
{06A147ED-15EA-4106-9105-9B745125B470}.Release-Intrinsics|Any CPU.Build.0 = Release-Intrinsics|Any CPU
{06A147ED-15EA-4106-9105-9B745125B470}.Release-netfx|Any CPU.ActiveCfg = Release-netfx|Any CPU
{06A147ED-15EA-4106-9105-9B745125B470}.Release-netfx|Any CPU.Build.0 = Release-netfx|Any CPU
{85D0CAFD-2FE8-496A-88C7-585D35B94243}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{85D0CAFD-2FE8-496A-88C7-585D35B94243}.Debug|Any CPU.Build.0 = Debug|Any CPU
{85D0CAFD-2FE8-496A-88C7-585D35B94243}.Debug-Intrinsics|Any CPU.ActiveCfg = Debug-Intrinsics|Any CPU
{85D0CAFD-2FE8-496A-88C7-585D35B94243}.Debug-Intrinsics|Any CPU.Build.0 = Debug-Intrinsics|Any CPU
{85D0CAFD-2FE8-496A-88C7-585D35B94243}.Debug-netfx|Any CPU.ActiveCfg = Debug-netfx|Any CPU
{85D0CAFD-2FE8-496A-88C7-585D35B94243}.Debug-netfx|Any CPU.Build.0 = Debug-netfx|Any CPU
{85D0CAFD-2FE8-496A-88C7-585D35B94243}.Release|Any CPU.ActiveCfg = Release|Any CPU
{85D0CAFD-2FE8-496A-88C7-585D35B94243}.Release|Any CPU.Build.0 = Release|Any CPU
{85D0CAFD-2FE8-496A-88C7-585D35B94243}.Release-Intrinsics|Any CPU.ActiveCfg = Release-Intrinsics|Any CPU
{85D0CAFD-2FE8-496A-88C7-585D35B94243}.Release-Intrinsics|Any CPU.Build.0 = Release-Intrinsics|Any CPU
{85D0CAFD-2FE8-496A-88C7-585D35B94243}.Release-netfx|Any CPU.ActiveCfg = Release-netfx|Any CPU
{85D0CAFD-2FE8-496A-88C7-585D35B94243}.Release-netfx|Any CPU.Build.0 = Release-netfx|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -974,6 +994,8 @@ Global
{9E689AD4-F908-493C-B882-B1B33E8F7696} = {D3D38B03-B557-484D-8348-8BADEE4DF592}
{8D8CC016-0020-40EC-BD8E-73F1CE0F9662} = {D3D38B03-B557-484D-8348-8BADEE4DF592}
{A84717CB-F11A-41C5-A74D-C0F1D47B7431} = {D3D38B03-B557-484D-8348-8BADEE4DF592}
{85D0CAFD-2FE8-496A-88C7-585D35B94243} = {09EADF06-BE25-4228-AB53-95AE3E15B530}
{31D38B21-102B-41C0-9E0A-2FE0BF68D123} = {D3D38B03-B557-484D-8348-8BADEE4DF592}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {41165AF1-35BB-4832-A189-73060F82B01D}
Expand Down
12 changes: 12 additions & 0 deletions pkg/Microsoft.Data.DataView/Microsoft.Data.DataView.nupkgproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk" DefaultTargets="Pack">

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<PackageDescription>Contains the IDataView system which is a set of interfaces and components that provide efficient, compositional processing of schematized data for machine learning and advanced analytics applications.</PackageDescription>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />
</ItemGroup>

</Project>
5 changes: 5 additions & 0 deletions pkg/Microsoft.Data.DataView/Microsoft.Data.DataView.symbols.nupkgproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<Project DefaultTargets="Pack">

<Import Project="Microsoft.Data.DataView.nupkgproj" />

</Project>
1 change: 1 addition & 0 deletions pkg/Microsoft.ML/Microsoft.ML.nupkgproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="../Microsoft.Data.DataView/Microsoft.Data.DataView.nupkgproj" />
<ProjectReference Include="../Microsoft.ML.CpuMath/Microsoft.ML.CpuMath.nupkgproj" />

<PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonPackageVersion)" />
Expand Down
Loading