Follow up from Extract IDataView feedback #2296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed one read instead of two.
eerhardt
requested review from
Ivanidzo4ka,
stephentoub,
TomFinley and
sfilipi
Codecov Report
@@ Coverage Diff @@
## master #2296 +/- ##
=========================================
+ Coverage 66.72% 70.02% +3.3%
=========================================
Files 783 783
Lines 144003 144006 +3
Branches 16605 16605
=========================================
+ Hits 96083 100846 +4763
+ Misses 43446 38610 -4836
- Partials 4474 4550 +76
|
TomFinley
reviewed
Jan 29, 2019
| @@ -950,16 +949,18 @@ public static Double[] DiscountMap | |||
| { | |||
| get | |||
| { | |||
| if (_discountMap == null) | |||
| double[] result = _discountMap; | |||
| if (result == null) | |||
| { | |||
| var discountMap = new Double[100]; //Hard to believe anyone would set truncation Level higher than 100 | |||
There was a problem hiding this comment.
Hard to believe anyone would set truncation Level higher than 100 [](start = 57, length = 65)
Comments like this raise my confidence in code a lot.
TomFinley
approved these changes
Jan 29, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stephentoub left some PR comments on #2220 after it was merged. Addressing those comments here.