Skip to content

Remnants from renaming of StratificationColumn #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2019
Merged

Remnants from renaming of StratificationColumn #2839

merged 1 commit into from
Mar 4, 2019

Conversation

najeeb-kazmi
Copy link
Member

Fixes #2536 remnants.

@codecov
Copy link

codecov bot commented Mar 4, 2019 •
edited
Loading

Codecov Report

Merging #2839 into master will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master    #2839   +/-   ##
=======================================
  Coverage    71.7%    71.7%           
=======================================
  Files         809      809           
  Lines      142491   142491           
  Branches    16116    16116           
=======================================
  Hits       102176   102176           
- Misses      35883    35884    +1     
+ Partials     4432     4431    -1
Flag Coverage Δ
#Debug 71.7% <50%> (ø) ⬆️
#production 67.93% <50%> (ø) ⬆️
#test 85.9% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.Data/TrainCatalog.cs 90.08% <50%> (ø) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 82.66% <0%> (-0.21%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 85.69% <0%> (+0.16%) ⬆️

rogancarr
rogancarr approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@rogancarr rogancarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈

@najeeb-kazmi najeeb-kazmi merged commit 63a7654 into dotnet:master Mar 4, 2019
@shauheen shauheen added this to the 0319 milestone Mar 4, 2019
@najeeb-kazmi najeeb-kazmi deleted the 2536 branch January 30, 2020 01:18
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

@rogancarr rogancarr rogancarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0319
Development

Successfully merging this pull request may close these issues.
4 participants
@najeeb-kazmi @Ivanidzo4ka @rogancarr @shauheen