Skip to content

Scrubbing task: rest of transforms #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Conversation

artidoro
Copy link
Contributor

@artidoro artidoro commented Mar 7, 2019

Fixes: #2835.

This PR does the scrubbing for the following transforms:

  • ReplaceMissingValues
  • IndicateMissingValues
  • CustomMapping

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #2876 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2876      +/-   ##
==========================================
+ Coverage   71.69%   71.71%   +0.02%     
==========================================
  Files         811      812       +1     
  Lines      142546   142676     +130     
  Branches    16125    16124       -1     
==========================================
+ Hits       102193   102321     +128     
- Misses      35924    35941      +17     
+ Partials     4429     4414      -15
Flag Coverage Δ
#Debug 71.71% <100%> (+0.02%) ⬆️
#production 67.89% <100%> (-0.02%) ⬇️
#test 85.99% <100%> (+0.08%) ⬆️
Impacted Files Coverage Δ
...rc/Microsoft.ML.Transforms/CustomMappingCatalog.cs 100% <ø> (ø) ⬆️
src/Microsoft.ML.Transforms/ExtensionsCatalog.cs 75% <100%> (ø) ⬆️
....ML.Transforms/MissingValueIndicatorTransformer.cs 69.66% <100%> (ø) ⬆️
...s/Api/CookbookSamples/CookbookSamplesDynamicApi.cs 80.4% <100%> (ø) ⬆️
src/Microsoft.ML.FastTree/RegressionTree.cs 71.42% <0%> (-12.25%) ⬇️
...oft.ML.Data/Dirty/ChooseColumnsByIndexTransform.cs 91.85% <0%> (-5.93%) ⬇️
...c/Microsoft.ML.SamplesUtils/SamplesDatasetUtils.cs 18.88% <0%> (-4.85%) ⬇️
src/Microsoft.ML.Data/Transforms/RangeFilter.cs 69.51% <0%> (-2.85%) ⬇️
...rc/Microsoft.ML.Data/Scorers/RowToRowScorerBase.cs 88.06% <0%> (-2.47%) ⬇️
...t.ML.Data/Transforms/ValueToKeyMappingEstimator.cs 85.18% <0%> (-1.61%) ⬇️
... and 39 more

@rogancarr
Copy link
Contributor

rogancarr commented Mar 7, 2019

        public bool IsUnderThirty { get; set; }

Move to first entry (because it's a label) or alphabetize the list. #Resolved


Refers to: docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/CustomMappingSample.cs:58 in 0f5ecdc. [](commit_id = 0f5ecdc, deletion_comment = False)

Copy link
Contributor

@rogancarr rogancarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, then it's ready for the limelight.
👨‍🚀 🛰 👾

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@artidoro artidoro self-assigned this Mar 7, 2019
@artidoro artidoro added the API Issues pertaining the friendly API label Mar 7, 2019
@artidoro artidoro added this to the 0319 milestone Mar 7, 2019
@artidoro artidoro merged commit e14db27 into dotnet:master Mar 8, 2019
@artidoro artidoro deleted the resttransform branch March 13, 2019 17:55
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants