Skip to content

Add Cancellation checkpoint in Normalizer transfomer. #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2019
Merged

Add Cancellation checkpoint in Normalizer transfomer. #3062

merged 2 commits into from
Mar 22, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Mar 22, 2019 •
edited
Loading

fixes #3070

@codecov
Copy link

codecov bot commented Mar 22, 2019 •
edited
Loading

Codecov Report

Merging #3062 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3062      +/-   ##
==========================================
- Coverage   72.52%    72.5%   -0.02%     
==========================================
  Files         804      804              
  Lines      144150   144151       +1     
  Branches    16179    16179              
==========================================
- Hits       104542   104520      -22     
- Misses      35195    35221      +26     
+ Partials     4413     4410       -3
Flag Coverage Δ
#Debug 72.5% <100%> (-0.02%) ⬇️
#production 68.13% <100%> (-0.02%) ⬇️
#test 88.72% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.Data/Transforms/Normalizer.cs 84.78% <100%> (+0.03%) ⬆️
src/Microsoft.ML.Core/Data/ProgressReporter.cs 70.95% <0%> (-6.99%) ⬇️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 89.26% <0%> (-0.63%) ⬇️

TomFinley
TomFinley approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codemzs !

@codemzs codemzs requested a review from sfilipi March 22, 2019 21:19
@sfilipi sfilipi merged commit df1c72f into dotnet:master Mar 22, 2019
@codemzs codemzs mentioned this pull request Apr 2, 2019
Merged
@antoniovs1029 antoniovs1029 mentioned this pull request Jan 13, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomFinley TomFinley TomFinley approved these changes

@sfilipi sfilipi sfilipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Cancellation checkpoint in Normalizer transfomer
3 participants
@codemzs @TomFinley @sfilipi