Skip to content

Download images only when not present on disk and print warning messages when converting unsupported pixel format. #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 1, 2019
Merged

Download images only when not present on disk and print warning messages when converting unsupported pixel format. #3625

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a43b01d
Load images without lock in transformer and print warning messages wh…
codemzs Apr 30, 2019
408f4c1
Improve warning message.
codemzs Apr 30, 2019
8495a29
cleanup.
codemzs Apr 30, 2019
f081269
Add test for warning message.
codemzs Apr 30, 2019
b19d63e
PR feedback.
codemzs May 1, 2019
651f89e
fix log message assert.:
codemzs May 1, 2019
3cf65da
fix log message assert.:
codemzs May 1, 2019
aac5365
fix log message assert.:
codemzs May 1, 2019
3babeb3
fix log message assert.
codemzs May 1, 2019
37cd817
cleanup.
codemzs May 1, 2019
133fbe1
PR feedback.
codemzs May 1, 2019
8bd0479
PR feedback.
codemzs May 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PR feedback.
  • Loading branch information
@codemzs
codemzs committed May 1, 2019
commit b19d63e2f4ad6e2ebbb62a54e2674fbdc37411fe
7 changes: 5 additions & 2 deletions src/Microsoft.ML.ImageAnalytics/ImageLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,13 @@ protected override Delegate MakeGetter(DataViewRow input, int iinfo, Func<int, b
if (!string.IsNullOrWhiteSpace(_parent.ImageFolder))
path = Path.Combine(_parent.ImageFolder, path);

using (var stream = new FileStream(path, FileMode.Open, FileAccess.Read))
MemoryStream inMemoryCopy = new MemoryStream();
using (FileStream fs = File.OpenRead(path))
{
dst = new Bitmap(stream) { Tag = path };
fs.CopyTo(inMemoryCopy);
}

dst = new Bitmap(inMemoryCopy) { Tag = path };
}
catch (Exception)
{
Expand Down