Brew install libomp 7.0.0 only. #3721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artidoro
approved these changes
May 15, 2019
There was a problem hiding this comment.
As mentioned in person, I think we should make sure we are working on fixing this temporary solution.
However, since any new PR is blocked right now I think this fix is fine for now.
If I understand correctly @najeeb-kazmi is going to work on fixing the build with libomp 8.0.0.
Codecov Report
@@ Coverage Diff @@
## master #3721 +/- ##
==========================================
+ Coverage 72.77% 72.78% +<.01%
==========================================
Files 808 808
Lines 145588 145588
Branches 16250 16250
==========================================
+ Hits 105956 105961 +5
+ Misses 35207 35203 -4
+ Partials 4425 4424 -1
|
eerhardt
approved these changes
May 15, 2019
|
@eerhardt I’m no home brew expert either but based on my research this afternoon it seems this is apparently the right way to install an earlier version of libomp. Thanks for approving. |
najeeb-kazmi
added a commit
that referenced
this pull request
May 15, 2019
#3676) * Fix SoftMax precision by utilizing double in the internal calculations * Brew install libomp 7.0.0 only. (#3721) * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Fix SoftMax precision by utilizing double in the internal calculations
najeeb-kazmi
added a commit
that referenced
this pull request
May 15, 2019
* Fix documentation for LightGbm parameter * Brew install libomp 7.0.0 only. (#3721) * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Fix documentation for LightGbm parameter
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop gap fix until #3722 is fixed.