Skip to content

These changes allow for ML.NET to be built from source by VS2019 #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 17, 2019
Merged

These changes allow for ML.NET to be built from source by VS2019 #3742

merged 4 commits into from
May 17, 2019

Conversation

PranovD
Copy link
Contributor

@PranovD PranovD commented May 16, 2019

Fixes #3739

@dnfclas
Copy link

dnfclas commented May 16, 2019 •
edited by codemzs
Loading

CLA assistant check
All CLA requirements met. #Closed

@codemzs codemzs self-requested a review May 17, 2019 01:07
@codemzs
Copy link
Member

codemzs commented May 17, 2019 •
edited
Loading

@PranovD Great first PR on day 4 of your internship! I have few minor comments but otherwise looks great.

Also adding @eerhardt and @safern , our build experts to also take a look! #Closed

@codemzs codemzs requested review from eerhardt and safern May 17, 2019 07:25
@PranovD PranovD changed the title These changes allow for ML.NET to be built from source by VS2019 #3739 These changes allow for ML.NET to be built from source by VS2019 May 17, 2019
codemzs
codemzs approved these changes May 17, 2019
View reviewed changes
Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@PranovD
Merge pull request #1 from dotnet/master
7b9a6a9 
Added sample for WithOnFitDelegate (dotnet#3738)
@PranovD PranovD merged commit b0fdb44 into dotnet:master May 17, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codemzs codemzs codemzs approved these changes

@safern safern safern approved these changes

@eerhardt eerhardt Awaiting requested review from eerhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to build ML.NET from source with Visual Studio 2019
4 participants
@PranovD @dnfclas @codemzs @safern