Skip to content

Access indices array for VBuffer in KeyToVector transformer only when resulting vector is sparse. #3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented May 22, 2019

fixes #3757
fixes #1751
fixes #2678

@codemzs codemzs requested review from eerhardt and yaeldekel May 22, 2019 09:37
@codemzs codemzs changed the title Access indices array for VBuffer in KeyToValue transformer only when resulting vector is sparse. Access indices array for VBuffer in KeyToVector transformer only when resulting vector is sparse. May 22, 2019
@codemzs codemzs requested a review from wschin May 22, 2019 20:28
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yaeldekel yaeldekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit 51b10fc into dotnet:master May 22, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants