Skip to content

Change ensembles trainer to work with ITrainerEstimators instead of ITrainers #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 1, 2019
Merged

Change ensembles trainer to work with ITrainerEstimators instead of ITrainers #3796

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6ae3a9
Change ensembles trainer to work with ITrainerEstimators instead of I…
yaeldMS May 30, 2019
94c26b7
Use NumberParseOptions.UseSingle when comparing baselines
yaeldMS Jun 11, 2019
51100d1
Decrease number of digits of precision
yaeldMS Jun 11, 2019
bcee4aa
Decrease number of digits of precision in some tests
yaeldMS Jun 11, 2019
17d8c9f
Disable some tests on netcoreapp3.0
yaeldMS Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Decrease number of digits of precision in some tests
  • Loading branch information
@yaeldMS
yaeldMS committed Jun 11, 2019
commit bcee4aa4ba65fde688c23f6ce3264eca366e0d56
12 changes: 6 additions & 6 deletions test/Microsoft.ML.Predictor.Tests/TestPredictors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2195,23 +2195,23 @@ public void EnsemblesDefaultTest()
{
// This one does CV as well as TrainTest.
var pa = new PredictorAndArgs(new SubComponent("WeightedEnsemble", "nm=20 tp=-"), "WE-Default");
RunOneAllTests(pa, TestDatasets.breastCancer, new[] { "loader=Text{col=Label:BL:0 col=Features:R4:1-9}" }, digitsOfPrecision: 6, parseOption: NumberParseOption.UseSingle);
RunOneAllTests(pa, TestDatasets.breastCancer, new[] { "loader=Text{col=Label:BL:0 col=Features:R4:1-9}" }, digitsOfPrecision: 5, parseOption: NumberParseOption.UseSingle);
Done();
}

[Fact]
public void EnsemblesBaseLearnerTest()
{
var pa = new PredictorAndArgs(new SubComponent("WeightedEnsemble", "bp=AvgPer nm=3 tp=-"), "WE-AvgPer");
Run_TrainTest(pa, TestDatasets.breastCancer, new[] { "loader=Text{col=Label:BL:0 col=Features:R4:1-9}" }, digitsOfPrecision: 6, parseOption: NumberParseOption.UseSingle);
Run_TrainTest(pa, TestDatasets.breastCancer, new[] { "loader=Text{col=Label:BL:0 col=Features:R4:1-9}" }, digitsOfPrecision: 5, parseOption: NumberParseOption.UseSingle);
Done();
}

[Fact]
public void EnsemblesHeterogeneousTest()
{
var pa = new PredictorAndArgs(new SubComponent("WeightedEnsemble", "bp=svm bp=ap nm=20 tp=-"), "WE-Hetero");
Run_TrainTest(pa, TestDatasets.breastCancer, new[] { "loader=Text{col=Label:BL:0 col=Features:R4:1-9}" }, digitsOfPrecision: 6, parseOption: NumberParseOption.UseSingle);
Run_TrainTest(pa, TestDatasets.breastCancer, new[] { "loader=Text{col=Label:BL:0 col=Features:R4:1-9}" }, digitsOfPrecision: 5, parseOption: NumberParseOption.UseSingle);
Done();
}

Expand Down Expand Up @@ -2243,7 +2243,7 @@ public void EnsemblesAveragerCombinerTest()
public void EnsemblesBestPerformanceSelectorTest()
{
var pa = new PredictorAndArgs(new SubComponent("WeightedEnsemble", "nm=20 pt=BestPerformanceSelector tp=-"), "WE-BestPerf");
Run_TrainTest(pa, TestDatasets.breastCancer, new[] { "loader=Text{col=Label:BL:0 col=Features:R4:1-9}" }, digitsOfPrecision: 5, parseOption: NumberParseOption.UseSingle);
Run_TrainTest(pa, TestDatasets.breastCancer, new[] { "loader=Text{col=Label:BL:0 col=Features:R4:1-9}" }, digitsOfPrecision: 4, parseOption: NumberParseOption.UseSingle);
Done();
}

Expand All @@ -2259,7 +2259,7 @@ public void EnsemblesBestDiverseSelectorTest()
public void EnsemblesRandomPartitionInstanceSelectorTest()
{
var pa = new PredictorAndArgs(new SubComponent("WeightedEnsemble", "nm=5 st=RandomPartitionSelector tp=-"), "WE-RandomPartition");
Run_TrainTest(pa, TestDatasets.breastCancer, new[] { "loader=Text{col=Label:BL:0 col=Features:R4:1-9}" }, digitsOfPrecision: 5, parseOption: NumberParseOption.UseSingle);
Run_TrainTest(pa, TestDatasets.breastCancer, new[] { "loader=Text{col=Label:BL:0 col=Features:R4:1-9}" }, digitsOfPrecision: 4, parseOption: NumberParseOption.UseSingle);
Done();
}

Expand All @@ -2275,7 +2275,7 @@ public void EnsemblesAllDataSetSelectorTest()
public void EnsemblesRandomSubSpaceSelectorTest()
{
var pa = new PredictorAndArgs(new SubComponent("WeightedEnsemble", "nm=20 st=AllInstanceSelector{fs=RandomFeatureSelector} tp=-"), "WE-RandomFeature");
Run_TrainTest(pa, TestDatasets.breastCancer, new[] { "loader=Text{col=Label:BL:0 col=Features:R4:1-9}" }, digitsOfPrecision: 6, parseOption: NumberParseOption.UseSingle);
Run_TrainTest(pa, TestDatasets.breastCancer, new[] { "loader=Text{col=Label:BL:0 col=Features:R4:1-9}" }, digitsOfPrecision: 5, parseOption: NumberParseOption.UseSingle);
Done();
}

Expand Down