Skip to content

Add overload for time series checkpoint API that takes a stream #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2019
Merged

Add overload for time series checkpoint API that takes a stream #3805

merged 2 commits into from
Jun 3, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Jun 3, 2019

fixes #3804

eerhardt
eerhardt approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. just some random thoughts.

@codemzs codemzs requested a review from artidoro June 3, 2019 17:23
ganik
ganik approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@ganik ganik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit 33e45ba into dotnet:master Jun 3, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@ganik ganik ganik approved these changes

@wschin wschin Awaiting requested review from wschin

@yaeldekel yaeldekel Awaiting requested review from yaeldekel

@ebarsoumMS ebarsoumMS Awaiting requested review from ebarsoumMS

@Ivanidzo4ka Ivanidzo4ka Awaiting requested review from Ivanidzo4ka

@artidoro artidoro Awaiting requested review from artidoro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add overload for time series checkpoint API that takes a stream
3 participants
@codemzs @eerhardt @ganik