Skip to content

Check for number of input columns in concat transform #3809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

abgoswam
Copy link
Member

@abgoswam abgoswam commented Jun 3, 2019

Fixes #3061

The PR makes the following changes:

  • Follows Solution A mentioned in the issue
  • Added a unit test

@abgoswam abgoswam requested review from codemzs and artidoro June 3, 2019 19:26
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:


try
{
var pipe = ML.Transforms.Concatenate("Features");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concatenate [](start = 41, length = 11)

maybe it make sense to remove params from inputColumnNames in Concatenate method?

Copy link
Member

@najeeb-kazmi najeeb-kazmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@abgoswam abgoswam merged commit 2ddb9ee into dotnet:master Jun 3, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null Reference Exception when Concatenating with a single value
4 participants