Tree based trainers implement ICanGetSummaryAsIDataView #3892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artidoro
commented
Jun 20, 2019
wschin
reviewed
Jun 20, 2019
| @@ -3378,7 +3361,7 @@ public TreeNode(Dictionary<string, object> keyValues) | |||
| /// and <see cref="TreeEnsembleModelParametersBasedOnRegressionTree"/> is the type of | |||
| /// <see cref="TrainedTreeEnsemble"/>. | |||
| /// </summary> | |||
| public abstract class TreeEnsembleModelParametersBasedOnRegressionTree : TreeEnsembleModelParameters | |||
| public abstract class TreeEnsembleModelParametersBasedOnRegressionTree : TreeEnsembleModelParameters, ICanGetSummaryAsIDataView | |||
There was a problem hiding this comment.
Why do we need ICanGetSummaryAs...? IDataView RegressionTreeEnsembleAsIDataView(..) looks sufficient for generating a summary. #ByDesign
There was a problem hiding this comment.
That's the interface that Summarize entrypoint uses to get the IDataView from a trainer.
See:
And:
artidoro
force-pushed
the
fasttreesummary2
branch
from
81a5d39 to
9b0e097
Compare
artidoro
commented
Jun 28, 2019
| /// Used for the Summarize entrypoint. | ||
| /// </summary> | ||
| IDataView ICanGetSummaryAsIDataView.GetSummaryDataView(RoleMappedSchema schema) | ||
| => RegressionTreeBaseUtils.RegressionTreeEnsembleAsIDataView(Host, TrainedTreeEnsemble.Bias, TrainedTreeEnsemble.TreeWeights, TrainedTreeEnsemble.Trees); |
artidoro
commented
Jun 28, 2019
| [LightGBMFact] | ||
| public void LightGbmBinaryClassificationTestSummary() | ||
| { | ||
| var (pipeline, dataView) = GetBinaryClassificationPipeline(); |
There was a problem hiding this comment.
GetBinaryClassificationPipeline [](start = 39, length = 31)
Make sure that these work with the categorical split after one hot encoding.
wschin
approved these changes
Jun 29, 2019
codemzs
approved these changes
Jun 29, 2019
artidoro
force-pushed
the
fasttreesummary2
branch
from
d6bf2c4 to
78f4f86
Compare
Dmitry-A
pushed a commit
to Dmitry-A/machinelearning
that referenced
this pull request
Jul 24, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3755.
NimbusML did not have access to the details on the tree structure.
This PR implements the
ICanGetSummaryAsIDataViewinterface which is used in theSummarizeentrypoint to pass a summary of the model parameters to NimbusML in the form of anIDataView.I create a utility method that does the conversion from
RegressionTreeBasetoIDataViewwith special treatment forQuantileRegressionTreeswhich have additional information.In the
IDataView, each node has its own row and the columns correspond to the fields describing each node. To determine which tree the node belongs to there is aTreeIDcolumn.