Skip to content

pack CodeGen into mlnet #4179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LittleLittleCloud
Copy link
Contributor

No description provided.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

/cc @Dmitry-A for FYI

@@ -107,5 +107,12 @@
<DependentUpon>ModelOutputClass.tt</DependentUpon>
</Compile>
</ItemGroup>

<Import Project="..\mlnet\mlnet.Build.props" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to add a comment to why we are doing this. From AutoML.csproj:

<!-- here we place this assembly into CLI package dir so it gets included in CLI nuget -->

@LittleLittleCloud LittleLittleCloud merged commit 22edabb into dotnet:features/automl Sep 9, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants