Skip to content

Issue 4120 #4297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 4, 2019
Merged

Issue 4120 #4297

merged 10 commits into from
Oct 4, 2019

Conversation

frank-dong-ms-zz
Copy link
Contributor

Follow up on Issue #4120

  1. Use EditorBrowsable attribute to hide the default constructor from intellisense.
  2. Use Obsolete("XX", false) instead of Obsolete("XX", true) to be safe.

@frank-dong-ms-zz frank-dong-ms-zz requested a review from a team as a code owner October 4, 2019 22:04
@frank-dong-ms-zz
Copy link
Contributor Author

@ericstj is added to the review. #Closed

@codemzs codemzs requested a review from ericstj October 4, 2019 22:14
eerhardt
eerhardt approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@82f83a6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4297   +/-   ##
=========================================
  Coverage          ?   74.61%           
=========================================
  Files             ?      878           
  Lines             ?   154218           
  Branches          ?    16868           
=========================================
  Hits              ?   115072           
  Misses            ?    34402           
  Partials          ?     4744
Flag Coverage Δ
#Debug 74.61% <ø> (?)
#production 70.21% <ø> (?)
#test 89.53% <ø> (?)
Impacted Files Coverage Δ
...c/Microsoft.ML.OnnxTransformer/OnnxSequenceType.cs 88.23% <ø> (ø)

@frank-dong-ms-zz frank-dong-ms-zz merged commit 60fea03 into dotnet:master Oct 4, 2019
@eerhardt eerhardt mentioned this pull request Oct 9, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codemzs codemzs codemzs approved these changes

@eerhardt eerhardt eerhardt approved these changes

@ericstj ericstj ericstj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frank-dong-ms-zz @codemzs @eerhardt @ericstj @frank-dong-ms