Add Code Gen piece for Recommendation task #4360

maryamariyan · 2019-10-21T21:27:22Z

Adds CodeGen piece for recommendation task
Cherry-picks changes in AutoML Add Recommendation Task #4246 into features/automl branch
Cross check mlnet tests build and run fine
confirm AutoML project tests build and run fine

Trains Recommendation models able to predict rating for existing users Conflicts: pkg/Microsoft.ML.AutoML/Microsoft.ML.AutoML.nupkgproj src/Microsoft.ML.AutoML/Microsoft.ML.AutoML.csproj test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs test/Microsoft.ML.AutoML.Tests/ColumnInferenceTests.cs test/Microsoft.ML.AutoML.Tests/ColumnInformationUtilTests.cs test/Microsoft.ML.AutoML.Tests/Microsoft.ML.AutoML.Tests.csproj test/Microsoft.ML.AutoML.Tests/TrainerExtensionsTests.cs test/Microsoft.ML.AutoML.Tests/TransformInferenceTests.cs test/Microsoft.ML.AutoML.Tests/UserInputValidationTests.cs

LittleLittleCloud · 2019-10-21T21:33:00Z

src/Microsoft.ML.AutoML/Microsoft.ML.AutoML.csproj

-    <PackageReference Include="Microsoft.ML.Mkl.Components" Version="$(MlDotNetPackageVersion)" />
-    <PackageReference Include="Microsoft.ML.Recommender" Version="$(MlDotNetPackageVersion)" />
+    <PackageReference Include="Microsoft.ML" Version="1.4.0-preview3-28218-2" />
+    <PackageReference Include="Microsoft.ML.LightGBM" Version="1.4.0-preview3-28218-2" />


Should it be LightGbm?

note: LightGbm in all uppercasing is also in nupkgproj files (pkg..AutoML and pkg\mlnet)

LittleLittleCloud · 2019-10-21T21:36:35Z

Microsoft.ML.AutoML.sln

@@ -1,6 +1,6 @@
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio 15
-VisualStudioVersion = 15.0.28010.2050	
+# Visual Studio Version 16


Is this change necessary?

no it's not. I can remove this

LittleLittleCloud · 2019-10-21T21:37:24Z

Microsoft.ML.AutoML.sln

@@ -18,6 +18,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tools-local", "tools-local"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.CodeGenerator", "src\Microsoft.ML.CodeGen\Microsoft.ML.CodeGenerator.csproj", "{3148A8CF-A686-4A9C-A5C6-C3E41CAAD64D}"
 EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.Recommender", "src\Microsoft.ML.Recommender\Microsoft.ML.Recommender.csproj", "{19D6A195-657E-42D9-A5D4-ECB289BB6FDA}"
+EndProject


Why Recommender appears in AutoML solution?

Refer to https://github.com/dotnet/machinelearning/pull/4246/files#diff-466b4b1a71c2aede1d30fa02d412ddc3

eerhardt · 2019-10-21T21:37:52Z

src/Microsoft.ML.AutoML/Microsoft.ML.AutoML.csproj

+  </ItemGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\Microsoft.ML.Recommender\Microsoft.ML.Recommender.csproj" />


Why aren't you using a PackageReference to Recommender here, same as the other 3?

eerhardt · 2019-10-21T21:38:27Z

src/Microsoft.ML.CodeGen/Microsoft.ML.CodeGenerator.csproj

@@ -15,98 +18,10 @@
  <ItemGroup>
    <ProjectReference Include="..\Microsoft.ML.AutoML\Microsoft.ML.AutoML.csproj" />
  </ItemGroup>
-
-  <ItemGroup>


I don't think you want these to be removed, do you?

bringing back

LittleLittleCloud · 2019-10-21T21:39:18Z

pkg/Microsoft.ML.AutoML/Microsoft.ML.AutoML.nupkgproj

@@ -4,11 +4,11 @@
    <TargetFramework>netstandard2.0</TargetFramework>
    <PackageDescription>ML.NET AutoML: Optimizes an ML pipeline for your dataset, by automatically locating the best feature engineering, model, and hyperparameters</PackageDescription>
  </PropertyGroup>
-
  <ItemGroup>
    <PackageReference Include="Microsoft.ML" Version="1.3.1" />
    <PackageReference Include="Microsoft.ML.LightGBM" Version="1.3.1" />


shouldn't it be LightGbm ?

eerhardt · 2019-10-21T21:39:33Z

src/Microsoft.ML.CodeGen/CodeGenerator/CSharp/TrainerGenerators.cs

+                    {
+                        {"MatrixColumnIndexColumnName","matrixColumnIndexColumnName" },
+                        {"MatrixRowIndexColumnName","matrixRowIndexColumnName" },
+                        {"FeatureColumnName","featureColumnName" },


I don't see a FeatureColumnName on MatrixFactorization

LittleLittleCloud · 2019-10-21T21:40:35Z

src/Microsoft.ML.AutoML/TaskKind.cs

@@ -9,5 +9,6 @@ internal enum TaskKind
        BinaryClassification,
        MulticlassClassification,
        Regression,
+        Recommendation


Please add trail comma :)

To keep the code style in format

note: I could change but this is cherry pick though. it is without trail comma in master branch as well.

This is code in master. We shouldn't be changing it here. If we want a change like that, make it in the master branch.

Honestly, the only thing this branch should be used for is Code Gen and mlnet.csproj going forward. Until they are merged into master. Then this branch should go away.

LittleLittleCloud · 2019-10-21T21:44:11Z

src/Microsoft.ML.CodeGen/Microsoft.ML.CodeGenerator.csproj

@@ -7,6 +7,9 @@

  <ItemGroup>
    <PackageReference Include="Microsoft.CodeAnalysis" Version="2.10.0" />
+    <!--<PackageReference Include="Microsoft.ML.AutoML" Version="0.16.0-preview3-28218-2" />-->
+    <PackageReference Include="Microsoft.ML" Version="1.4.0-preview3-28218-2" />


Why we need Microsoft.ML package in CodeGen.

Please remove comment BTW

LittleLittleCloud · 2019-10-21T21:44:51Z

src/Microsoft.ML.CodeGen/Microsoft.ML.CodeGenerator.csproj

@@ -15,98 +18,10 @@
  <ItemGroup>
    <ProjectReference Include="..\Microsoft.ML.AutoML\Microsoft.ML.AutoML.csproj" />
  </ItemGroup>
-
-  <ItemGroup>


Why we remove tt file in this case

bringing back

LittleLittleCloud · 2019-10-21T21:46:57Z

src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs

@@ -273,6 +273,11 @@ internal static class Defaults

        PredictionKind ITrainer.PredictionKind => PredictionKind.Recommendation;

+        /// <summary>
+        /// The <see cref="TrainerInfo"/> contains general parameters for this trainer.


Seems that you just do a useless copy-paste here (see the change below). Could you just recover it back since it's unnecessary

LittleLittleCloud · 2019-10-21T21:47:52Z

test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs

@@ -2,9 +2,11 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.

+using System;
+using System.IO;


The import order seems not right,,, doesn't StyleCop not grumble about it?

LittleLittleCloud · 2019-10-21T21:49:37Z

test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs

@@ -60,5 +62,92 @@ public void AutoFitRegressionTest()

            Assert.IsTrue(result.RunDetails.Max(i => i.ValidationMetrics.RSquared > 0.9));
        }
+
+        [TestMethod]
+        public void AutoFitRecommendationTest()


I like this end-to-end test, seems really insightful.

maryamariyan · 2019-10-21T22:59:50Z

Thanks for the review. Halting progress on the PR and could reopen it once the blockers for this work item have been identified.

danmoseley · 2019-10-28T18:08:18Z

src/Microsoft.ML.AutoML/TrainerExtensions/RecommendationTrainerExtensions.cs

+
+namespace Microsoft.ML.AutoML
+{
+    using ITrainerEsitmator = ITrainerEstimator<IPredictionTransformer<object>, object>;


typo ITrainerEsitmator

LittleLittleCloud and others added 4 commits October 21, 2019 13:29

part1

2d6e19b

part2 automl test still not picking up cpunative

1863918

Add Recommender proj to AutoML sln

b7a7573

maryamariyan changed the title ~~Codegen recommendation~~ Add Code Gen piece for Recommendation task Oct 21, 2019

LittleLittleCloud reviewed Oct 21, 2019

View reviewed changes

eerhardt reviewed Oct 21, 2019

View reviewed changes

LittleLittleCloud reviewed Oct 21, 2019

View reviewed changes

eerhardt reviewed Oct 21, 2019

View reviewed changes

LittleLittleCloud reviewed Oct 21, 2019

View reviewed changes

maryamariyan closed this Oct 21, 2019

danmoseley reviewed Oct 28, 2019

View reviewed changes

ghost locked as resolved and limited conversation to collaborators Mar 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Code Gen piece for Recommendation task #4360

Add Code Gen piece for Recommendation task #4360

maryamariyan commented Oct 21, 2019

LittleLittleCloud Oct 21, 2019

maryamariyan Oct 21, 2019

LittleLittleCloud Oct 21, 2019

maryamariyan Oct 21, 2019

LittleLittleCloud Oct 21, 2019

maryamariyan Oct 21, 2019

eerhardt Oct 21, 2019

eerhardt Oct 21, 2019

maryamariyan Oct 21, 2019

LittleLittleCloud Oct 21, 2019

eerhardt Oct 21, 2019

LittleLittleCloud Oct 21, 2019

LittleLittleCloud Oct 21, 2019

maryamariyan Oct 21, 2019

eerhardt Oct 21, 2019

LittleLittleCloud Oct 21, 2019

LittleLittleCloud Oct 21, 2019

maryamariyan Oct 21, 2019

LittleLittleCloud Oct 21, 2019

LittleLittleCloud Oct 21, 2019

LittleLittleCloud Oct 21, 2019

maryamariyan commented Oct 21, 2019 •

edited

Loading

danmoseley Oct 28, 2019

Add Code Gen piece for Recommendation task #4360

Add Code Gen piece for Recommendation task #4360

Conversation

maryamariyan commented Oct 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maryamariyan commented Oct 21, 2019 • edited Loading

Choose a reason for hiding this comment

maryamariyan commented Oct 21, 2019 •

edited

Loading