Skip to content

Hash Transform API that takes in advanced options. #4443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 6, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Nov 5, 2019

fixes #4422

Needed by a 1P customer.

@codemzs codemzs requested a review from eerhardt November 5, 2019 21:12
@codemzs codemzs requested a review from a team as a code owner November 5, 2019 21:12
@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9fc8f1c). Click here to learn what that means.
The diff coverage is 91.66%.

@@            Coverage Diff            @@
##             master    #4443   +/-   ##
=========================================
  Coverage          ?   74.71%           
=========================================
  Files             ?      906           
  Lines             ?   159289           
  Branches          ?    17145           
=========================================
  Hits              ?   119011           
  Misses            ?    35476           
  Partials          ?     4802
Flag Coverage Δ
#Debug 74.71% <91.66%> (?)
#production 70.07% <82.35%> (?)
#test 90.11% <100%> (?)
Impacted Files Coverage Δ
test/Microsoft.ML.Tests/Transformers/HashTests.cs 100% <100%> (ø)
...icrosoft.ML.TestFramework/DataPipe/TestDataPipe.cs 91.27% <100%> (ø)
src/Microsoft.ML.Transforms/OneHotHashEncoding.cs 84.92% <100%> (ø)
...ML.Data/Transforms/ConversionsExtensionsCatalog.cs 70.87% <100%> (ø)
...soft.ML.Data/DataLoadSave/DataOperationsCatalog.cs 78.45% <100%> (ø)
...L.Transforms/Text/WordHashBagProducingTransform.cs 61.08% <50%> (ø)
src/Microsoft.ML.Data/Transforms/Hashing.cs 92.34% <81.81%> (ø)

@eerhardt
Copy link
Member

eerhardt commented Dec 5, 2019

Do you want to add a new functional test that uses the new advanced options? That way we ensure the actual API works as users will use it. #Resolved

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this new API looks good to me. It should be ready to go in when we have functional tests covering the new API.

@codemzs
Copy link
Member Author

codemzs commented Dec 6, 2019

@eerhardt I have added the functional test you asked for (even though I had a unit-test called HashWorkout that exercised this routine). Since the API looks good to you and is ready to go so I will check-in this PR (because I need to provide the nuget today) but if you have more comments please make here and I will include them in a separate PR.

@codemzs codemzs merged commit 85e2de2 into dotnet:master Dec 6, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ML.net doesn't exposes useOrderedHashing input parameter for Hash transformation
3 participants