Skip to content

Fixed model saving and loading of OneVersusAllTrainer to include SoftMax #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2019
Merged

Fixed model saving and loading of OneVersusAllTrainer to include SoftMax #4472

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77214cd
Fixed model saving and loading of OneVersusAllTrainer to include SoftMax
harishsk Nov 12, 2019
b59fb17
Modified existing test to include SoftMax option
harishsk Nov 13, 2019
0a5dada
Modified test to verify both cases: when UseSoftmax is true and false
harishsk Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Modified existing test to include SoftMax option
  • Loading branch information
@harishsk
harishsk committed Nov 13, 2019
commit b59fb174d3959aec1d013dd2215d5e27fbf39a24
4 changes: 3 additions & 1 deletion test/Microsoft.ML.Tests/TrainerEstimators/TreeEstimators.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,9 @@ public void LightGbmMulticlassEstimatorWithOptions()
{
var options = new LightGbmMulticlassTrainer.Options
{
EvaluationMetric = LightGbmMulticlassTrainer.Options.EvaluateMetricType.Default
EvaluationMetric = LightGbmMulticlassTrainer.Options.EvaluateMetricType.Default,
UseSoftmax = true
Copy link
Contributor

@justinormont justinormont Nov 13, 2019 •
edited by harishsk
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want two unit tests total; both setting it explicitly as true and false. I believe the hyerparameter defaults to <auto>, where LightGBM decides for you. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks!

In reply to: 345950381 [](ancestors = 345950381)


};

var (pipeline, dataView) = GetMulticlassPipeline();
Expand Down