Skip to content

Avoid running API Compat for design time builds #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2019

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Dec 6, 2019

This change prevents the API compat tool from failing design time builds and leaving the IDE project model in a bad state for development.

@sharwell sharwell requested a review from a team as a code owner December 6, 2019 22:37
Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #4529 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4529      +/-   ##
==========================================
+ Coverage   75.11%   75.13%   +0.01%     
==========================================
  Files         908      908              
  Lines      160238   160238              
  Branches    17256    17256              
==========================================
+ Hits       120362   120394      +32     
+ Misses      35060    35029      -31     
+ Partials     4816     4815       -1
Flag Coverage Δ
#Debug 75.13% <ø> (+0.01%) ⬆️
#production 70.53% <ø> (+0.02%) ⬆️
#test 90.31% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 84.6% <0%> (+0.15%) ⬆️
src/Microsoft.ML.Maml/MAML.cs 26.21% <0%> (+1.45%) ⬆️
...rosoft.ML.AutoML/ColumnInference/TextFileSample.cs 62.25% <0%> (+2.64%) ⬆️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 86.55% <0%> (+3.36%) ⬆️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 83.89% <0%> (+5.93%) ⬆️
src/Microsoft.ML.AutoML/Sweepers/ISweeper.cs 67.08% <0%> (+7.59%) ⬆️

This change prevents the API compat tool from failing design time builds
and leaving the IDE project model in a bad state for development.
@sharwell sharwell merged commit 813817b into dotnet:master Dec 8, 2019
@sharwell sharwell deleted the pass-design-time branch December 8, 2019 17:35
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants