-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Convert LdaEngine to a SafeHandle #4538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #4538 +/- ##
==========================================
+ Coverage 75.12% 75.12% +<.01%
==========================================
Files 908 908
Lines 160214 160220 +6
Branches 17250 17250
==========================================
+ Hits 120355 120365 +10
+ Misses 35045 35039 -6
- Partials 4814 4816 +2
|
This comment has been minimized.
This comment has been minimized.
0cbfa54
to
bd45716
Compare
With changes to the native library now merged (#4551), I reduced this pull request to the minimum necessary to stabilize the use of this particular handle. It specifically fixes cases where this exception appears in test runs:
|
This pull request follows the test failure observed in https://dev.azure.com/dnceng/public/_build/results?buildId=449759&view=ms.vss-test-web.build-test-results-tab&runId=14347330&resultId=100770&paneView=debug. Converting this object to a SafeHandle has two primary advantages: