Skip to content

Update code coverage integration #4543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2019
Merged

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Dec 7, 2019

  • Simplifies coverage integration
  • Removes the need to define CODECOV_TOKEN during builds

@codemzs codemzs self-requested a review December 7, 2019 20:25
@codecov
Copy link

codecov bot commented Dec 7, 2019

Codecov Report

Merging #4543 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4543      +/-   ##
==========================================
+ Coverage   75.11%   75.13%   +0.01%     
==========================================
  Files         908      908              
  Lines      160238   160238              
  Branches    17256    17256              
==========================================
+ Hits       120362   120388      +26     
+ Misses      35060    35033      -27     
- Partials     4816     4817       +1
Flag Coverage Δ
#Debug 75.13% <ø> (+0.01%) ⬆️
#production 70.52% <ø> (+0.02%) ⬆️
#test 90.31% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 85.11% <0%> (-0.21%) ⬇️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 84.6% <0%> (+0.15%) ⬆️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.26% <0%> (+0.15%) ⬆️
src/Microsoft.ML.Maml/MAML.cs 26.21% <0%> (+1.45%) ⬆️
...rosoft.ML.AutoML/ColumnInference/TextFileSample.cs 62.25% <0%> (+2.64%) ⬆️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 83.05% <0%> (+5.08%) ⬆️
src/Microsoft.ML.AutoML/Sweepers/ISweeper.cs 67.08% <0%> (+7.59%) ⬆️

@sharwell
Copy link
Member Author

sharwell commented Dec 8, 2019

This build appears to have the expected results (no coverage changes). Marking as ready for review.

@sharwell sharwell marked this pull request as ready for review December 8, 2019 17:51
@sharwell sharwell requested a review from a team as a code owner December 8, 2019 17:51
@sharwell sharwell merged commit cc1c967 into dotnet:master Dec 8, 2019
@sharwell sharwell deleted the update-codecov branch December 8, 2019 19:50
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants