Skip to content

Add tests for IParameterValue implementations #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Dec 8, 2019

This change provides deterministic coverage for the implementation of LongParameterValue, FloatParameterValue, and StringParameterValue.

This change provides deterministic coverage for the implementation
of LongParameterValue, FloatParameterValue, and StringParameterValue.
@sharwell sharwell requested a review from a team as a code owner December 8, 2019 18:28
@codecov
Copy link

codecov bot commented Dec 8, 2019

Codecov Report

Merging #4549 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4549      +/-   ##
==========================================
+ Coverage   75.13%   75.14%   +<.01%     
==========================================
  Files         908      908              
  Lines      160238   160289      +51     
  Branches    17256    17256              
==========================================
+ Hits       120401   120442      +41     
- Misses      35016    35031      +15     
+ Partials     4821     4816       -5
Flag Coverage Δ
#Debug 75.14% <100%> (ø) ⬆️
#production 70.52% <ø> (-0.02%) ⬇️
#test 90.34% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
test/Microsoft.ML.AutoML.Tests/SweeperTests.cs 59.17% <100%> (+17.64%) ⬆️
src/Microsoft.ML.Core/Data/ProgressReporter.cs 70.95% <0%> (-6.99%) ⬇️
...rosoft.ML.AutoML/ColumnInference/TextFileSample.cs 59.6% <0%> (-2.65%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
...soft.ML.TestFramework/DataPipe/TestDataPipeBase.cs 76.47% <0%> (+0.39%) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 85.31% <0%> (+0.6%) ⬆️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.32% <0%> (+1.27%) ⬆️
...L.AutoML/TrainerExtensions/TrainerExtensionUtil.cs 86.89% <0%> (+1.74%) ⬆️
test/Microsoft.ML.AutoML.Tests/DatasetUtil.cs 91.3% <0%> (+2.6%) ⬆️

Copy link
Contributor

@justinormont justinormont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharwell sharwell merged commit 30ebfc3 into dotnet:master Dec 9, 2019
@sharwell sharwell deleted the coverage-noise-1 branch December 9, 2019 06:32
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants