Skip to content

fix issue 4528, use thread safe ConcurrentDictionary instead of Dictionary #4570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 13, 2019
Merged

fix issue 4528, use thread safe ConcurrentDictionary instead of Dictionary #4570

merged 4 commits into from
Dec 13, 2019

Conversation

frank-dong-ms-zz
Copy link
Contributor

fix issue #4528

@frank-dong-ms
fix issue 4528, use thread safe ConcurrentDictionary instead of Dicti…
98ded1d 
…onary which is not thread safe in read/write mode
@frank-dong-ms-zz frank-dong-ms-zz requested a review from a team as a code owner December 12, 2019 23:34
@codecov
Copy link

codecov bot commented Dec 13, 2019 •
edited
Loading

Codecov Report

Merging #4570 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4570      +/-   ##
==========================================
+ Coverage   75.13%   75.13%   +<.01%     
==========================================
  Files         909      909              
  Lines      160262   160262              
  Branches    17257    17257              
==========================================
+ Hits       120409   120411       +2     
+ Misses      35041    35038       -3     
- Partials     4812     4813       +1
Flag Coverage Δ
#Debug 75.13% <ø> (ø) ⬆️
#production 70.53% <ø> (ø) ⬆️
#test 90.3% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
...soft.ML.TestFramework/DataPipe/TestDataPipeBase.cs 76.08% <0%> (-0.4%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 85.11% <0%> (-0.21%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.1% <0%> (-0.16%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 26.21% <0%> (+1.45%) ⬆️
...L.AutoML/TrainerExtensions/TrainerExtensionUtil.cs 86.89% <0%> (+1.74%) ⬆️

@frank-dong-ms-zz
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@frank-dong-ms-zz frank-dong-ms-zz merged commit 5aa9e67 into dotnet:master Dec 13, 2019
@frank-dong-ms-zz frank-dong-ms-zz deleted the issue-4528 branch December 18, 2019 20:08
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sharwell sharwell sharwell approved these changes

@eerhardt eerhardt Awaiting requested review from eerhardt

@harishsk harishsk Awaiting requested review from harishsk

@codemzs codemzs Awaiting requested review from codemzs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frank-dong-ms-zz @sharwell @frank-dong-ms