-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixes #4571. About memory leak when using FeaturizeText. #4576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
antoniovs1029
merged 21 commits into
dotnet:master
from
antoniovs1029:is15NormStrLeak2Sols
Dec 18, 2019
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
1182b91
Proposal to change NormStr
antoniovs1029 19a2d0a
Proposal to change TextNormalizingTransformer.Mapper
antoniovs1029 d2f6528
Added Proposal 3 - Modifying NormStr.Pool.Get
antoniovs1029 20cb8de
Revert "Proposal to change NormStr"
antoniovs1029 c3a1174
Revert "Proposal to change TextNormalizingTransformer.Mapper"
antoniovs1029 d36ea8e
Added flag to control creation of a new str
antoniovs1029 eca5b13
Added Benchmark Test
antoniovs1029 62af85b
Added minor comment to benchmark
antoniovs1029 e82485b
Nit - Fixed references to PRs and Issues
antoniovs1029 3dfa0b9
Nit - renamed flag in NormStr.Pool.Get()
antoniovs1029 198caed
Added space
antoniovs1029 48892ea
Added duplicateStr prameter to NormStr.Pool.Add method
antoniovs1029 ba5dadd
Changed threshold in FeaturizeText Benchmark to be 400MB instead of 1GB
antoniovs1029 94b2424
Typo
antoniovs1029 a5eb6c8
Changed threshold to 240MB
antoniovs1029 ce181b6
Added Benchmark output
antoniovs1029 25d6250
Removed Assertion from Benchmark
antoniovs1029 70886fe
Added test with memory usage assertion
antoniovs1029 b5766fb
Updated test comment
antoniovs1029 c94a293
Comment out test Console.WriteLine
antoniovs1029 2998b05
Removing test
antoniovs1029 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "Proposal to change TextNormalizingTransformer.Mapper"
This reverts commit 19a2d0a.
- Loading branch information
commit c3a1174fff7047b9506983e5919cb61b22feaee8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.