Skip to content

retry and disable tests to get stable CI #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from

Conversation

frank-dong-ms-zz
Copy link
Contributor

Due to test in private agent pool, these 2 tests seems crashing test host process, try to disable them.

https://dev.azure.com/dnceng/public/_build?definitionId=712&_a=summary

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #4669 into master will decrease coverage by 0.15%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master    #4669      +/-   ##
==========================================
- Coverage   75.82%   75.67%   -0.16%     
==========================================
  Files         951      951              
  Lines      172292   172325      +33     
  Branches    18589    18590       +1     
==========================================
- Hits       130648   130405     -243     
- Misses      36467    36739     +272     
- Partials     5177     5181       +4
Flag Coverage Δ
#Debug 75.67% <63.63%> (-0.16%) ⬇️
#production 71.34% <66.66%> (-0.09%) ⬇️
#test 90.2% <61.9%> (-0.41%) ⬇️
Impacted Files Coverage Δ
...icrosoft.ML.TestFramework/DataPipe/TestDataPipe.cs 91.99% <ø> (ø) ⬆️
test/Microsoft.ML.TimeSeries.Tests/TimeSeries.cs 87.85% <ø> (ø) ⬆️
...est/Microsoft.ML.Predictor.Tests/TestPredictors.cs 66.66% <ø> (-1.28%) ⬇️
...ests/TrainerEstimators/MatrixFactorizationTests.cs 84.94% <ø> (-12.91%) ⬇️
test/Microsoft.ML.Tests/OnnxConversionTest.cs 97.66% <ø> (ø) ⬆️
...osoft.ML.Tests/TrainerEstimators/TreeEstimators.cs 93.26% <ø> (-4.81%) ⬇️
...crosoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs 98.36% <ø> (ø) ⬆️
...cenariosWithDirectInstantiation/TensorflowTests.cs 87.66% <ø> (-4.43%) ⬇️
...ML.Tests/Scenarios/IrisPlantClassificationTests.cs 100% <ø> (ø) ⬆️
...s/Api/CookbookSamples/CookbookSamplesDynamicApi.cs 95.48% <ø> (ø) ⬆️
... and 17 more

@sharwell
Copy link
Member

Can we use #4666 instead of this?

@frank-dong-ms-zz
Copy link
Contributor Author

I am not intend to check this in, disable test is bad thing, this is only for test to see whether we see less crash or not


In reply to: 575671268 [](ancestors = 575671268)

@frank-dong-ms-zz frank-dong-ms-zz changed the title skip 2 lightgbm related test to avoid test host process crash retry and disable tests to get stable CI Jan 18, 2020
Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@frank-dong-ms-zz frank-dong-ms-zz deleted the crash-lightgbm branch February 3, 2020 21:35
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants