Skip to content

Fixes cases of invalid image folder path and input column name #4691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2020

Conversation

mstfbl
Copy link
Contributor

@mstfbl mstfbl commented Jan 22, 2020

Fixes #4429

Input column names and image folders can no longer be empty or null.

@mstfbl mstfbl requested a review from a team as a code owner January 22, 2020 11:15
@antoniovs1029
Copy link
Member

antoniovs1029 commented Jan 22, 2020

Hi, @mstfbl

About the exception thrown if the inputFolder doesn't exist, that's generally ok. If anything, I left some comments there.

About the other changes in ImageAnalytics/ExtensionsCatalog.cs they're not ok. I am afraid I didn't explain myself clearly on issue #4429 , so I am thinking about updating that issue in order to make it more clear. The issue isn't that inputColumnName can be null, the problem I described there is that the inputColumn can be empty for all rows (i.e. that content of the column, for every row, is empty) and the trainer would still train and classify every row.

So I would revert the changes you made in that file, since the behavior it had for them was actually all right (i.e. if inputColumnName is null then it should default to outputColumnName, as this is done throughout our API).

@antoniovs1029
Copy link
Member

antoniovs1029 commented Jan 22, 2020

Also, it seems that all of the pipelines are failing because of the changes on the imageFolder parameter. It seems it's supposed to be an optional parameter, so it should actually support being "null". In that case I guess you should also remove the changes you made to that, and only check if inputFolder exists if it wasn't "null" to begin with.

@mstfbl
Copy link
Contributor Author

mstfbl commented Jan 23, 2020

Thanks @antoniovs1029 for your review. I made new changes after reviewing your input. I'll make a new PR to implement the other changes once you clarify your issue.

@mstfbl mstfbl requested a review from antoniovs1029 January 23, 2020 11:31
@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d85be83). Click here to learn what that means.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master    #4691   +/-   ##
=========================================
  Coverage          ?   75.83%           
=========================================
  Files             ?      951           
  Lines             ?   172384           
  Branches          ?    18613           
=========================================
  Hits              ?   130734           
  Misses            ?    36474           
  Partials          ?     5176
Flag Coverage Δ
#Debug 75.83% <66.66%> (?)
#production 71.42% <66.66%> (?)
#test 90.62% <ø> (?)
Impacted Files Coverage Δ
src/Microsoft.ML.ImageAnalytics/ImageLoader.cs 85.11% <66.66%> (ø)

@antoniovs1029
Copy link
Member

Thanks @antoniovs1029 for your review. I made new changes after reviewing your input. I'll make a new PR to implement the other changes once you clarify your issue.

Hi, I had added my clarifications on the issue. Idk if it's clear enough, though, let me know if you need further explanations. Thanks!

@mstfbl mstfbl merged commit 7fd93e6 into dotnet:master Jan 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoadImages not warning that input column is empty and ignoring imageFolder parameter in such a case
3 participants