-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixes cases of invalid image folder path and input column name #4691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, @mstfbl About the exception thrown if the inputFolder doesn't exist, that's generally ok. If anything, I left some comments there. About the other changes in So I would revert the changes you made in that file, since the behavior it had for them was actually all right (i.e. if inputColumnName is null then it should default to outputColumnName, as this is done throughout our API). |
Also, it seems that all of the pipelines are failing because of the changes on the imageFolder parameter. It seems it's supposed to be an optional parameter, so it should actually support being "null". In that case I guess you should also remove the changes you made to that, and only check if inputFolder exists if it wasn't "null" to begin with. |
Thanks @antoniovs1029 for your review. I made new changes after reviewing your input. I'll make a new PR to implement the other changes once you clarify your issue. |
Codecov Report
@@ Coverage Diff @@
## master #4691 +/- ##
=========================================
Coverage ? 75.83%
=========================================
Files ? 951
Lines ? 172384
Branches ? 18613
=========================================
Hits ? 130734
Misses ? 36474
Partials ? 5176
|
Hi, I had added my clarifications on the issue. Idk if it's clear enough, though, let me know if you need further explanations. Thanks! |
Fixes #4429
Input column names and image folders can no longer be empty or null.