-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Cherrypick to update release for V0.3 #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding xml style documentation for lbfgs, sdca and averagerPerceptron trainers, to improve what's currently on docs.microsoft.com * regenerating the C#Api file * Removing the control characters from the description when generating the ep_list.tsv, so that they have one line per entry point. Formatting. * spaces * The epList.tsv file and the manifest should not have the platform specific new line characters. * merge fix
…o console app. (#452) * Add LightGBM to the entrypoint manifest and references to trainers and transform including native code to console command line binary. * Add documentation to use LightGBM nuget for LightGBM APIs.
* Make options culture agnostic.
Add more documentation for OneVersusAll
* updating the C# api generator to append the Remarks XML to the generated Summary class XML. Adding documentation details and references for another batch of the trainers. * correcting test trigger condition * typo * More documentation * substituting the <see> and <seealso> tags with <a> tags, since there is no official documentation on using href with those tags. * adressing PR comments. Fixing new line character in the ep_list and manifest. * Fixing the list and code generation merges from master
TomFinley
approved these changes
Jul 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need some way to improve this process going forward.
eerhardt
approved these changes
Jul 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick into release for v0.3