Fix for KeytoValue transformer #4866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishsk
reviewed
Feb 20, 2020
| var dstVariableName = ctx.AddIntermediateVariable(_types[iinfo], info.outputColumnName, true); | ||
| if (!_kvMaps[iinfo].SaveOnnx(ctx, inputColumnName, dstVariableName)) | ||
| if (!_kvMaps[iinfo].SaveOnnx(ctx, srcVariableName, dstVariableName)) |
There was a problem hiding this comment.
I think it would be a good idea to add a test case specifically because we don't have tests for this. Also please verify this fixes the Nimbus issue.
There was a problem hiding this comment.
Sounds good. I restructured the tests and got rid of a KeyToValue test that seems redundant and is not formatted to test different types of values.
harishsk
approved these changes
Feb 21, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a small bug where the source variable name of an ONNX graph was mistakenly always the input variable name, which is not always the case. Other ONNX transformers don't explicitly test for this functionality, so I didn't add a test case.