Fix for MulticlassNaiveBayesTrainer export to Onnx #4928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Lynx1820
commented
Mar 10, 2020
Lynx1820
commented
- Adding support for a batch input dimension
- While ML.NET doesn't use this batch dimension, ORT does.
harishsk
reviewed
Mar 10, 2020
...crosoft.ML.StandardTrainers/Standard/MulticlassClassification/MulticlassNaiveBayesTrainer.cs
Show resolved
Hide resolved
harishsk
reviewed
Mar 11, 2020
| var opType = "Greater"; | ||
| ctx.CreateNode(opType, new[] { featureColumn, zero }, new[] { greaterOutput }, ctx.GetNodeName(opType), ""); | ||
|
|
||
| opType = "Cast"; | ||
| var isFeaturePresent = ctx.AddIntermediateVariable(null, "isFeaturePresent", true); | ||
| var node = ctx.CreateNode(opType, greaterOutput, isFeaturePresent, ctx.GetNodeName(opType), ""); | ||
| var castOutput = ctx.AddIntermediateVariable(new VectorDataViewType(NumberDataViewType.Single, _featureHistogram[0].Length), "castOutput"); |
There was a problem hiding this comment.
new VectorDataViewType(NumberDataViewType.Single, _featureHistogram[0].Length) [](start = 57, length = 78)
There seem to be about two or three shapes involved here. Can you please create the shapes in one place at the top and reuse the shapes?
It would make the code more readable and make it easier to follow along?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.