Skip to content

Updated MultiFileSource.Load to fix inconsistent behavior with multiple files #5003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2020

Conversation

mstfbl
Copy link
Contributor

@mstfbl mstfbl commented Apr 7, 2020

Fixes #4982

MultiFileSource's Load can now accommodate loading from multiple paths. Also added more test cases for the additional features of MultiFileSource.

Example usages:
textLoader.Load("Data/*");
textLoader.Load("DataFolder/.../*");
textLoader.Load("DataFolder/SubFolder1/*", "DataFolder/SubFolder2/*");
textLoader.Load("DataFolder/SubFolder1/1.csv", "DataFolder/SubFolder2/2.csv");

@mstfbl mstfbl marked this pull request as ready for review April 7, 2020 01:40
@mstfbl mstfbl requested a review from a team as a code owner April 7, 2020 01:40
@frank-dong-ms-zz
Copy link
Contributor

frank-dong-ms-zz commented Apr 8, 2020

is there any place to describe the correct usage of wildcard of directory like below?
textLoader.Load("DataFolder/.../*"); #Resolved

@mstfbl
Copy link
Contributor Author

mstfbl commented Apr 8, 2020

@frank-dong-ms A description of the correct usage of wildcards for MultiFileSource doesn't exist in the original codebase. I have added a description on usage of wildcards with MultiFileSource to its XML documentation as a part of this PR. #Resolved

Copy link
Contributor

@frank-dong-ms-zz frank-dong-ms-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mstfbl mstfbl merged commit 1ea5336 into dotnet:master Apr 8, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextLoader Load From Multiple Files Inconsistent Behavior
2 participants