Added ability to compare configuration specific baselines #5045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishsk
requested review from
frank-dong-ms-zz,
antoniovs1029,
Lynx1820 and
mstfbl
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables BinaryClassifierSymSgdTest for x86 runs by adding a separate x86 specific baseline. In the process it also adds the ability enable other tests to have configuration specific baselines.
Some background on why configuration specific baseline is needed here:
The SymbolicSgd trainers call into native code in SymSgdNative.dll which in turn call into MklImports.dll to compute dot products. The cblas_sdot call in MKL returns different results for identical input on x86 and x64 based on computation history. MklImports.dll is built from the Intel MKL SDK. Trying to fix the MKL across x86 and x64 is is a much bigger work item than we have time for.
It is more important for us to enable these tests. So I am attempting this fix by providing different baselines for x86 and x64.