Fixed baselines between Debug and Release builds #5068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 9ad6989 successfully got rid of baselines that were differing in un-checked metrics. Commit 85dab51 and 1d80e35 replaces remaining baselines with those of SingleRelease baselines, as in my research the SingleRelease bechmarks are accurate and have passed on my local machine. However, if they doesn't pass on CLI, I will revert the last 2 commits. Update: As expected, this is passing on CI too. Therefore, this PR fixes all differing debug vs. release benchmark issues. |
…lease" directories
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most baselines in SingleDebug and SingleRelease test baseline folders are differing in fields that are not actively compared. Remaining baselines are differing in certain log-loss reduction values at the 10^-5'th digit, due to how the Release compiler does not round up or down values.
This PR handles such baselines by removing them from SingleDebug and SingleRelease folders, and by adding to Common folder. This PR also removes the checking of SingleDebug and SingleRelease folders in
BaseTestBaseline.GetBaselinePath().