Updated ORT version info for OnnxScoringEstimator #5175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyems
approved these changes
May 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #5175 +/- ##
===========================================
+ Coverage 75.81% 88.93% +13.11%
===========================================
Files 993 237 -756
Lines 181224 43104 -138120
Branches 19510 2266 -17244
===========================================
- Hits 137389 38333 -99056
+ Misses 38537 4453 -34084
+ Partials 5298 318 -4980
|
| /// Models are scored on CPU by default. | ||
| /// [Microsoft.ML.OnnxRuntime](https://www.nuget.org/packages/Microsoft.ML.OnnxRuntime/) library (version 1.3.0). | ||
| /// Models are scored on CPU if the project references Microsoft.ML.OnnxRuntime and on the GPU if the project references Microsoft.ML.OnnxRuntime.Gpu. | ||
| /// Every project using the OnnxScoringEstimator must reference one of the above two packages. | ||
| /// | ||
| /// To run on a GPU, use the | ||
| /// NuGet package [Microsoft.ML.OnnxRuntime.Gpu](https://www.nuget.org/packages/Microsoft.ML.OnnxRuntime.Gpu/) (version 1.2.0) instead of the Microsoft.ML.OnnxRuntime nuget (which is for CPU processing). Microsoft.ML.OnnxRuntime.Gpu |
There was a problem hiding this comment.
Also update this lines below to say that we use (version 1.3.0), or maybe even remove the "(version 1.2.0)" parenthesis since the version was already stated above.. Btw, Since this paragraph I'm pointing to also states that for Gpu support we need the Gpu nuget instead of the Cpu one it's a little bit redundant with the new lines introduced above. But that's ok I guess.
|
The text on line 716-717 still reads version 1.2.0. This was the line I was referring to in my previous comment, were I suggested removing the "(version 1.2.0)" parenthesis. Sorry for the confusion. |
antoniovs1029
approved these changes
May 28, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added additional detail around mandatory inclusion of either the CPU or the GPU nuget of ORT.