address build version issue and enhance logging #5268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5268 +/- ##
==========================================
+ Coverage 73.56% 73.64% +0.08%
==========================================
Files 1022 1022
Lines 189690 189690
Branches 20441 20441
==========================================
+ Hits 139539 139698 +159
+ Misses 44611 44473 -138
+ Partials 5540 5519 -21
|
harishsk
reviewed
Jun 30, 2020
| @@ -66,6 +66,8 @@ | |||
| <!-- Version properties --> | |||
| <PropertyGroup> | |||
| <VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix> | |||
| <BuildNumberMajor Condition="'$(BuildNumberMajor)' == ''">00001</BuildNumberMajor> | |||
| <BuildNumberMinor Condition="'$(BuildNumberMinor)' == ''">0</BuildNumberMinor> | |||
There was a problem hiding this comment.
Just curious. Is there a restriction on the format for BuildNumberMajor that it has to have the four leading zeros? #Resolved
There was a problem hiding this comment.
BuildNumberMajor is 5 digit number like 29008 so set default BuildNumberMajor as 00001
In reply to: 447871778 [](ancestors = 447871778)
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of issue #5266
This issue looks like a bug in msbuild versioning. This only happens when the build is crossing 2 days as msbuild versioning is generating versioning file each day so when some project starts to build when the system time is crossing to new day, seems msbuild versioning can't handle this case and read empty BuildNumberMajor and BuildNumberMinor sometimes which cause the assembly version number to be a invalid format.
I can repro this issue by set system time to a time very close to midnight, say 11:58 PM then start build from cmd, there is pretty good chance to repro the build version issue. Since we don't have a way to upgrade build tools now I will use default value of BuildNumberMajor and BuildNumberMinor to mitigate this issue.