-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Issue4484] Support specifying command timeout while using the database loader #5288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Microsoft.ML.Data/DataLoadSave/Database/DatabaseLoaderCursor.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #5288 +/- ##
==========================================
- Coverage 73.68% 69.51% -4.17%
==========================================
Files 1022 779 -243
Lines 190320 145811 -44509
Branches 20470 18576 -1894
==========================================
- Hits 140232 101366 -38866
+ Misses 44557 39273 -5284
+ Partials 5531 5172 -359
|
Codecov Report
@@ Coverage Diff @@
## master #5288 +/- ##
==========================================
+ Coverage 73.68% 73.75% +0.07%
==========================================
Files 1022 1022
Lines 190320 190360 +40
Branches 20470 20472 +2
==========================================
+ Hits 140232 140404 +172
+ Misses 44557 44439 -118
+ Partials 5531 5517 -14
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix issue 4484
-add option to set db command timeout in db loader
-add corresponding test
this pr partially refers to a hanging PR.