Skip to content

Replace whitelist terminology to allow list #5328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2020
Merged

Replace whitelist terminology to allow list #5328

merged 3 commits into from
Jul 28, 2020

Conversation

LetticiaNicoli
Copy link
Contributor

No description provided.

@LetticiaNicoli LetticiaNicoli requested review from a team as code owners July 28, 2020 00:08
@dnfadmin
Copy link

dnfadmin commented Jul 28, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

justinormont
justinormont reviewed Jul 28, 2020
View reviewed changes
src/Microsoft.ML.AutoML/Experiment/RecipeInference.cs
@@ -13,9 +13,9 @@ internal static class RecipeInference
/// </summary>
/// <returns>Array of viable learners.</returns>
public static IEnumerable<SuggestedTrainer> AllowedTrainers(MLContext mlContext, TaskKind task,
ColumnInformation columnInfo, IEnumerable<TrainerName> trainerWhitelist)
ColumnInformation columnInfo, IEnumerable<TrainerName> trainerAllowList)
Copy link
Contributor

@justinormont justinormont Jul 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harishsk, @sharwell : This isn't a breaking change, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a public API, then it could be a source-breaking change for someone who used explicitly named arguments. It wouldn't be a binary-breaking change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoML isn't part of ML.NET's stable API. So this should be okay I think. Is that correct @sharwell?

In reply to: 461252764 [](ancestors = 461252764)

Copy link
Member

@sharwell sharwell Jul 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to what is or is not part of the current stable public API. If this is not part of the stable public API, then it seems like it would be an easy change to approve.

justinormont
justinormont approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@justinormont justinormont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Before merging, can someone verify that this isn't a breaking change -- #5328 (review)

@codecov
Copy link

codecov bot commented Jul 28, 2020 •
edited
Loading

Codecov Report

Merging #5328 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5328      +/-   ##
==========================================
+ Coverage   73.91%   73.98%   +0.07%     
==========================================
  Files        1019     1019              
  Lines      190101   190101              
  Branches    20438    20438              
==========================================
+ Hits       140511   140651     +140     
+ Misses      44055    43931     -124     
+ Partials     5535     5519      -16
Flag Coverage Δ
#Debug 73.98% <100.00%> (+0.07%) ⬆️
#production 69.77% <100.00%> (+0.09%) ⬆️
#test 87.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oft.ML.Transforms/Text/TextFeaturizingEstimator.cs 90.57% <ø> (ø)
src/Microsoft.ML.AutoML/API/ExperimentBase.cs 76.02% <100.00%> (ø)
src/Microsoft.ML.AutoML/Experiment/Experiment.cs 81.25% <100.00%> (ø)
.../Microsoft.ML.AutoML/Experiment/RecipeInference.cs 100.00% <100.00%> (ø)
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 83.19% <100.00%> (-3.37%) ⬇️
...utoML/TrainerExtensions/TrainerExtensionCatalog.cs 97.79% <100.00%> (ø)
...icrosoft.ML.AutoML.Tests/TrainerExtensionsTests.cs 100.00% <100.00%> (ø)
src/Microsoft.ML.Maml/MAML.cs 23.78% <0.00%> (-0.98%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.32% <0.00%> (-0.85%) ⬇️
... and 11 more

@harishsk harishsk merged commit 6bae29f into dotnet:master Jul 28, 2020
@LetticiaNicoli LetticiaNicoli deleted the rename_whitelist_terminology branch July 29, 2020 17:17
@newgerstas
Copy link

Just for sake of curiosity. I hope this change has nothing to do with poisonous political correctness soaked into IT world? Why renaming a variable was market as a bugfix in release notes?

@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sharwell sharwell sharwell approved these changes

@harishsk harishsk harishsk approved these changes

@justinormont justinormont justinormont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LetticiaNicoli @dnfadmin @newgerstas @sharwell @justinormont @harishsk