fixes ort memory leak #5517
Closed
fixes ort memory leak #5517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
harishsk
reviewed
Dec 1, 2020
|
|
||
| ~OnnxRuntimeOutputCacher() | ||
| { | ||
| if (_isDisposed) |
There was a problem hiding this comment.
Does it ever hit this code path?
There was a problem hiding this comment.
The finalizer is hit. I dont think the Dispose call is though. I left it in cause it would be better to switch to a dispose call when we are able to.
There was a problem hiding this comment.
We shouldn't be using a finalizer here.
- We should ensure
OnnxRuntimeOutputCacherinstances get disposed properly. - In the cases where
Dispose()is never called by the user, and this object is no longer referenced, all the references to the underlyingDisposableNamedOnnxValuewill be removed as well. IfDisposableNamedOnnxValueis holding on to native memory, it should have a finalizer (or more preferrably use a SafeHandle). The managed object that manages the native memory is responsible for ensuring proper clean up.
We shouldn't be using finalizers to dispose managed objects. Finalizers should only be used for managing native resources.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the ORT memory leak by disposing of the NamedOnnxValues and makes the OnnxRuntimeOutputCacher disposable and adds a finalizer.