-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix #5767 issue with DataFrame Merge method #5768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5768 +/- ##
==========================================
- Coverage 68.38% 68.33% -0.06%
==========================================
Files 1131 1131
Lines 241019 241027 +8
Branches 25024 25026 +2
==========================================
- Hits 164822 164699 -123
- Misses 69714 69831 +117
- Partials 6483 6497 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, this LGTM!
Thank you for the PR @asmirnov82 ! Really appreciate the work here! |
You are welcome @pgovind. Do I need to click "Close PR" to merge it or you will merge it by yourself? |
I'm not sure how the permissions are set up in this repo. In this particular case, I'll do it because we're working on fixing the CI in this repo |
Thanks! |
@asmirnov82, I believe CI is fixed in the repo now. Can you rebase your PR on the latest dotnet/main? Edit: Never mind, I was able to do it within GitHub! |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Fixes #5767
Fix issue related to DataFrame Merge method with Algorithm.Inner, in case when right dataframe has more rows. that left