Skip to content

Use Append for not format string #5826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Use Append for not format string #5826

merged 1 commit into from
Jun 8, 2021

Conversation

feiyun0112
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #5826 (e2be0aa) into main (7c34ab9) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5826      +/-   ##
==========================================
- Coverage   68.37%   68.32%   -0.05%     
==========================================
  Files        1131     1131              
  Lines      241291   241291              
  Branches    25053    25053              
==========================================
- Hits       164993   164873     -120     
- Misses      69806    69916     +110     
- Partials     6492     6502      +10     
Flag Coverage Δ
Debug 68.32% <0.00%> (-0.05%) ⬇️
production 62.94% <0.00%> (-0.07%) ⬇️
test 89.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t.ML.FastTree/TreeEnsemble/InternalTreeEnsemble.cs 68.19% <0.00%> (ø)
src/Microsoft.ML.FastTree/Utils/Timer.cs 45.20% <0.00%> (ø)
...osoft.ML.KMeansClustering/KMeansPlusPlusTrainer.cs 83.60% <0.00%> (-7.16%) ⬇️
src/Microsoft.ML.Data/Training/TrainerUtils.cs 65.86% <0.00%> (-3.82%) ⬇️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 85.49% <0.00%> (-3.08%) ⬇️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 71.42% <0.00%> (-1.37%) ⬇️
...crosoft.ML.StandardTrainers/Optimizer/Optimizer.cs 71.96% <0.00%> (-1.16%) ⬇️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 91.46% <0.00%> (-1.03%) ⬇️
src/Microsoft.ML.Data/Utils/LossFunctions.cs 66.83% <0.00%> (-0.52%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.67% <0.00%> (+0.14%) ⬆️
... and 2 more

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelgsharp - it might be helpful to turn on more roslyn analyzers in dotnet/machinelearning so these things are checked and don't regress on new code.

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelgsharp michaelgsharp merged commit 4cb6d6c into dotnet:main Jun 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants