-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update issue templates #5846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update issue templates #5846
Conversation
name: Report a bug | ||
about: File a bug to help us improve ML.NET | ||
title: '' | ||
labels: '' | ||
assignees: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious what these are here for instead of just using the ones built into github? Or is it so that the submitter can put stuff there since they can't in github?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave them and see what happens. Are you thinking if they add an assignee or label that it will auto add it for us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think if we set it to something then it auto-adds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelgsharp is there something else I need to do to get it approved for merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments that would be good to fix.
Codecov Report
@@ Coverage Diff @@
## main #5846 +/- ##
==========================================
+ Coverage 68.39% 68.41% +0.01%
==========================================
Files 1134 1134
Lines 241910 241910
Branches 25109 25289 +180
==========================================
+ Hits 165465 165501 +36
+ Misses 69926 69787 -139
- Partials 6519 6622 +103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. And I just got in the PR to fix the CI. Waiting for these builds and then I'll merge this in tonight.
No description provided.