Skip to content

Update issue templates #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Update issue templates #5846

merged 4 commits into from
Jun 22, 2021

Conversation

briacht
Copy link
Contributor

@briacht briacht commented Jun 17, 2021

No description provided.

Comment on lines +2 to +6
name: Report a bug
about: File a bug to help us improve ML.NET
title: ''
labels: ''
assignees: ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what these are here for instead of just using the ones built into github? Or is it so that the submitter can put stuff there since they can't in github?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the GitHub UI to create these templates, and there were options to add title, labels, and assignees:

image

I just left them blank. Should I delete them from the markdown file too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave them and see what happens. Are you thinking if they add an assignee or label that it will auto add it for us?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think if we set it to something then it auto-adds

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelgsharp is there something else I need to do to get it approved for merge?

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments that would be good to fix.

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #5846 (286ef3b) into main (b3a3c66) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5846      +/-   ##
==========================================
+ Coverage   68.39%   68.41%   +0.01%     
==========================================
  Files        1134     1134              
  Lines      241910   241910              
  Branches    25109    25289     +180     
==========================================
+ Hits       165465   165501      +36     
+ Misses      69926    69787     -139     
- Partials     6519     6622     +103     
Flag Coverage Δ
Debug 68.41% <ø> (+0.01%) ⬆️
production 63.00% <ø> (+0.01%) ⬆️
test 89.31% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.ML.Core/Utilities/ArrayUtils.cs 87.75% <0.00%> (-8.17%) ⬇️
src/Microsoft.ML.TimeSeries/TimeSeriesUtils.cs 94.73% <0.00%> (-5.27%) ⬇️
src/Microsoft.ML.Core/Utilities/FixedSizeQueue.cs 76.47% <0.00%> (-3.53%) ⬇️
src/Microsoft.ML.Core/Utilities/Utils.cs 67.91% <0.00%> (-1.88%) ⬇️
src/Microsoft.ML.Core/Utilities/BigArray.cs 68.60% <0.00%> (-1.56%) ⬇️
...soft.ML.Data/Transforms/GenerateNumberTransform.cs 83.39% <0.00%> (-1.55%) ⬇️
src/Microsoft.ML.Data/Data/BufferBuilder.cs 75.71% <0.00%> (-1.43%) ⬇️
src/Microsoft.Data.Analysis/TextFieldParser.cs 71.28% <0.00%> (-1.40%) ⬇️
...Microsoft.ML.Data/Transforms/NormalizeColumnSng.cs 76.88% <0.00%> (-1.12%) ⬇️
...Microsoft.ML.Mkl.Components/OlsLinearRegression.cs 66.84% <0.00%> (-1.09%) ⬇️
... and 42 more

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. And I just got in the PR to fix the CI. Waiting for these builds and then I'll merge this in tonight.

@michaelgsharp michaelgsharp merged commit 7f888c2 into main Jun 22, 2021
@michaelgsharp michaelgsharp deleted the add-issue-templates branch June 22, 2021 07:43
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants