Skip to content

Fixes Macos CI issue #5854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Fixes Macos CI issue #5854

merged 1 commit into from
Jun 22, 2021

Conversation

michaelgsharp
Copy link
Member

Fixes the CI issues the mac builds and the libomp files.

@michaelgsharp michaelgsharp requested a review from a team June 21, 2021 22:46
@michaelgsharp michaelgsharp self-assigned this Jun 21, 2021
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have experience with this files, but seems reasonable.

Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as you try it and ensure it is working :-)

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #5854 (43d2c21) into main (ff01708) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5854      +/-   ##
==========================================
+ Coverage   68.35%   68.40%   +0.05%     
==========================================
  Files        1134     1134              
  Lines      241910   241910              
  Branches    25289    25289              
==========================================
+ Hits       165347   165475     +128     
+ Misses      69919    69800     -119     
+ Partials     6644     6635       -9     
Flag Coverage Δ
Debug 68.40% <ø> (+0.05%) ⬆️
production 62.98% <ø> (+0.06%) ⬆️
test 89.31% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 81.88% <0.00%> (-3.15%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 25.38% <0.00%> (-1.53%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.74% <0.00%> (-0.85%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.23% <0.00%> (-0.15%) ⬇️
src/Microsoft.ML.Data/Utils/LossFunctions.cs 67.35% <0.00%> (+0.51%) ⬆️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 92.15% <0.00%> (+1.02%) ⬆️
...crosoft.ML.StandardTrainers/Optimizer/Optimizer.cs 73.12% <0.00%> (+1.15%) ⬆️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 72.78% <0.00%> (+1.36%) ⬆️
test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs 89.04% <0.00%> (+1.96%) ⬆️
... and 4 more

@michaelgsharp michaelgsharp merged commit 442c29c into dotnet:main Jun 22, 2021
@michaelgsharp michaelgsharp deleted the mac-ci-fix branch June 22, 2021 05:41
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants