Add in VS 2022 support. #5956
Merged
Add in VS 2022 support. #5956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5956 +/- ##
==========================================
+ Coverage 68.19% 68.23% +0.04%
==========================================
Files 1142 1142
Lines 242367 242803 +436
Branches 25355 25385 +30
==========================================
+ Hits 165287 165686 +399
- Misses 70400 70421 +21
- Partials 6680 6696 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tarekgh
reviewed
Oct 5, 2021
tarekgh
approved these changes
Oct 5, 2021
safern
reviewed
Oct 8, 2021
|
This is just for building ML.NET. Do you think there is a need to remove the ability to build it on older versions of visual studio? I'm not sure if people are still using older versions or not. Is there a way to see? |
|
There is not, it is not a big deal, we just in dotnet/runtime remove support for the old ones where the TFMs we use are not even supported. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in support for VS 2022 in the native build.
Also added documentation stating the version of CMake needed for 2022.