Skip to content

Update WebClient to HttpClient implementations for downloading (WIP) #6476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 4, 2023
Merged

Update WebClient to HttpClient implementations for downloading (WIP) #6476

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a94c6cf
Initial structure and started fleshing out some sections
rgesteve Oct 19, 2022
9cda569
Some corrections and paragraph on DL usages
rgesteve Oct 19, 2022
f2f5fab
Starting fleshing out DL on ML.NET section
rgesteve Oct 20, 2022
b68c1a4
Merge pull request #1 from rgesteve/rgesteve/dl_overview
rgesteve Nov 4, 2022
df4300b
Merge branch 'main' of https://github.com/rgesteve/machinelearning in…
rgesteve Nov 16, 2022
adcec38
Merge branch 'main' into mine_main
rgesteve Nov 24, 2022
ec2d36f
Merge branch 'main' into mine_main
rgesteve Nov 29, 2022
f33004a
A HttpClient vs Webclient implementation
rgesteve Nov 29, 2022
805aad9
Removed download changes
michaelgsharp May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
A HttpClient vs Webclient implementation
  • Loading branch information
@rgesteve
rgesteve committed Nov 29, 2022
commit f33004afbba4db2d1b6f9f99593731548c5c5544
10 changes: 10 additions & 0 deletions docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/ImageClassification.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
using System.IO;
using System.Linq;
using System.Net;
using System.Net.Http;
using System.Text;
using System.Threading.Tasks;
using ICSharpCode.SharpZipLib.GZip;
using ICSharpCode.SharpZipLib.Tar;
using Microsoft.ML;
Expand Down Expand Up @@ -113,10 +115,18 @@ class OutputScores

private static string Download(string baseGitPath, string dataFile)
{
#if false
using (WebClient client = new WebClient())
{
client.DownloadFile(new Uri($"{baseGitPath}"), dataFile);
}
#else
var httpClient = new HttpClient();
using (var file = File.OpenWrite(dataFile))
{
httpClient.GetStreamAsync(baseGitPath).ContinueWith((Task<Stream> t) => t.Result.CopyToAsync(file));
}
#endif

return dataFile;
}
Expand Down