Skip to content

Onedal algorithms backed by nuget packages #6521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 66 commits into from
Dec 21, 2022
Merged

Onedal algorithms backed by nuget packages #6521

Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
5d1c55f
Add OneDal namespace
Alexsandruss Nov 11, 2022
4d38486
oneDAL algorithms wrapper
Alexsandruss Nov 11, 2022
df4caed
oneDAL Decision Forest integration
Alexsandruss Nov 11, 2022
646cfcd
oneDAL Linear Models
Alexsandruss Nov 11, 2022
9b913e7
oneDAL README
Alexsandruss Nov 11, 2022
3f30986
Fix mac lib path
Alexsandruss Nov 11, 2022
e34cb51
Fix cmake args for Win platform
Alexsandruss Nov 11, 2022
1592aa9
Fix cmake args for Win platform 2
Alexsandruss Nov 11, 2022
2324141
Modify building of onedal wrapper
Alexsandruss Nov 20, 2022
c6dc1c4
Temp.fix of wrapper deps
Alexsandruss Nov 21, 2022
2476425
Add onedal devel version
Alexsandruss Nov 21, 2022
3870283
Modify linking and add tbb libs copy
Alexsandruss Nov 21, 2022
e0e3cd4
Modify link to tbb[malloc]
Alexsandruss Nov 21, 2022
23e9c04
Fix tbb link
Alexsandruss Nov 21, 2022
60fd3aa
Fix tbb versions
Alexsandruss Nov 21, 2022
34da106
tbb linking fixes
Alexsandruss Nov 21, 2022
6ff47c5
Fix tbb linking 2
Alexsandruss Nov 21, 2022
1014d7e
Remove df_clsf inference from wrapper, fix msvc warnings
Alexsandruss Nov 21, 2022
0981764
Fix win linking
Alexsandruss Nov 21, 2022
c37debb
Fix linking on Windows
Alexsandruss Nov 21, 2022
12866e2
fix onedalutils
Alexsandruss Nov 22, 2022
b803f51
Fix usage of onedalutils
Alexsandruss Nov 22, 2022
1545e9d
Fix usage of onedalutils n2
Alexsandruss Nov 22, 2022
fd4bc39
Fix usage of onedalutils n3
Alexsandruss Nov 22, 2022
dbfb792
Fix usage of onedalutils n4
Alexsandruss Nov 22, 2022
057c0e9
Fix win compile options
Alexsandruss Nov 23, 2022
0428e69
Corrected some formatting issues
rgesteve Dec 4, 2022
62d3880
The logic (on linux) to download nuget packages
rgesteve Dec 4, 2022
10a8aa2
First cut trying to download packages on Windows
rgesteve Dec 5, 2022
cf67884
Added a sample for OneDal Random forest
rgesteve Dec 5, 2022
747682f
Merge branch 'onedal_with_nuget' of https://github.com/rgesteve/machi…
rgesteve Dec 5, 2022
0c9a00c
Move download functionality to msbuild
rgesteve Dec 5, 2022
d5f2442
OS-specific downloads
rgesteve Dec 5, 2022
16f7c7b
Revert changes to these files, as now using PackageDownloads instead
rgesteve Dec 6, 2022
4ab37db
Remove unused cmake variables
Alexsandruss Dec 6, 2022
512bf86
Merge branch 'alex_exp_onedal' into onedal_with_nuget
rgesteve Dec 6, 2022
f2aa4b1
Rebasing to main
rgesteve Dec 7, 2022
5875e31
Restore accessibility of ctor in favor of changes in AssemblyInfo
rgesteve Dec 8, 2022
075b48e
dependencies of benchmark driver
rgesteve Dec 12, 2022
d0de991
Small driver that installs dependencies and runs benchmarking scripts
rgesteve Dec 12, 2022
42012ba
Guard onedal as exclusive of x64 arch
rgesteve Dec 12, 2022
6afa6cb
Merge branch 'onedal_with_nuget' of https://github.com/rgesteve/machi…
rgesteve Dec 12, 2022
db39a8f
Consider MacOS builds
rgesteve Dec 13, 2022
858be56
Only build OneDal in x64 architectures
rgesteve Dec 13, 2022
6fb303b
The IS_64BIT_BUILD guard didn't work, switching to string comp
rgesteve Dec 13, 2022
ad499b2
Accomodate arch reporting on mac
rgesteve Dec 13, 2022
13b8931
Activate OneDal only on x64
rgesteve Dec 13, 2022
afae3ea
Only pass build parameters for onedal in x64
rgesteve Dec 14, 2022
7c01466
When on Windows, setting onedal to only build on x64
rgesteve Dec 14, 2022
6f47eac
Avoid CMake 'var not used' error
rgesteve Dec 14, 2022
07be9f3
Copy OneDal wrapper only on x64 architectures
rgesteve Dec 14, 2022
27827c1
OS-specific download (instead of same payload for linux/macos)
rgesteve Dec 15, 2022
e7368d7
fixed sln file
michaelgsharp Dec 15, 2022
e9c1436
A better range for average memory requirements, extra output breaks b…
rgesteve Dec 16, 2022
4b52f28
Merge branch 'onedal_with_nuget' of https://github.com/rgesteve/machi…
rgesteve Dec 16, 2022
371ccd9
Adding a unit test for OneDAL, and updating the usage notes
rgesteve Dec 16, 2022
68f0a17
Fixed styling for oneDAL and small syntax nitpicks
rgesteve Dec 16, 2022
52d4d6a
fixing onedal project not showing in VS
michaelgsharp Dec 16, 2022
3331545
Added temp test to probe loading libraries
rgesteve Dec 19, 2022
d8433e5
Merge branch 'onedal_with_nuget' of https://github.com/rgesteve/machi…
rgesteve Dec 19, 2022
d19621b
Displaying where this is (supposedly) reading Native DLLs
rgesteve Dec 19, 2022
5bfab70
Copy dependencies so that they're included in Microsoft.ML.OneDal nupkg
rgesteve Dec 19, 2022
e2a6094
Remove debugging tests
rgesteve Dec 20, 2022
35a18a1
Addressing having to set LD_LIBRARY_PATH manually
rgesteve Dec 20, 2022
a603030
Copy onedal dependencies to avoid assumption they include pdbs
rgesteve Dec 21, 2022
34ddbba
PATH manipulation on Win to account for dll loading
rgesteve Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Copy OneDal wrapper only on x64 architectures
  • Loading branch information
@rgesteve
rgesteve committed Dec 14, 2022
commit 07be9f3daa7c3a01e0b7dc0ea7e5d03d1ab3ea71
2 changes: 1 addition & 1 deletion src/Native/Native.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
RelativePath="Microsoft.ML.Mkl.Redist\runtimes\$(PackageRid)\native" />
<NativePackageAsset Condition="'$(NonArmOnWindows)' == 'true'" Include="$(NativeAssetsBuiltPath)\libiomp5md$(NativeLibExtension)"
RelativePath="Microsoft.ML.Mkl.Redist\runtimes\$(PackageRid)\native" />
<NativePackageAsset Condition="'$(TargetArchitecture)' != 'arm64' And '$(TargetArchitecture)' != 'arm'"
<NativePackageAsset Condition="'$(TargetArchitecture)' == 'x64'"
Include="$(NativeAssetsBuiltPath)\$(NativeLibPrefix)OneDalNative$(NativeLibExtension)"
RelativePath="Microsoft.ML.OneDal\runtimes\$(PackageRid)\native" />

Expand Down