Skip to content

Update timeout error message in AutoMLExperiment.cs #6613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

LittleLittleCloud
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

fix dotnet/machinelearning-modelbuilder#2500

Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LittleLittleCloud looks good. Just made some minor suggestions.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #6613 (0d4c786) into main (6002aa8) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6613      +/-   ##
==========================================
+ Coverage   68.39%   68.44%   +0.04%     
==========================================
  Files        1176     1176              
  Lines      248210   248210              
  Branches    25915    25915              
==========================================
+ Hits       169759   169882     +123     
+ Misses      71676    71567     -109     
+ Partials     6775     6761      -14     
Flag Coverage Δ
Debug 68.44% <ø> (+0.04%) ⬆️
production 62.83% <ø> (+0.06%) ⬆️
test 88.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@LittleLittleCloud LittleLittleCloud merged commit 7a2ac5c into main Apr 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 4, 2023
@michaelgsharp michaelgsharp deleted the LittleLittleCloud-patch-2 branch May 16, 2023 00:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw better error message when no suitable model is found.
4 participants