Fix DataFrame Null Math #6661
Merged
Fix DataFrame Null Math #6661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix math and update templates to match generated files.
JakeRadMSFT
commented
May 7, 2023
| @@ -844,7 +844,7 @@ public void TestComputations() | |||
| Assert.Equal(100.0, df.Columns["Double"].Max()); | |||
| Assert.Equal(-10.0f, df.Columns["Float"].Min()); | |||
| Assert.Equal((uint)0, df.Columns["Uint"].Product()); | |||
| Assert.Equal((ushort)140, df.Columns["Ushort"].Sum()); | |||
There was a problem hiding this comment.
{Ushort: 0 1 3 6 10 null 16 23 31 40 }
0+1+3+6+10+16+23+31+40 = 130
There was a problem hiding this comment.
@JakeRadMSFT is this how Pandas handles math with null data? We should match whatever they do.
Same issue?
Test and Fix Median and Mean
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6661 +/- ##
==========================================
+ Coverage 68.59% 68.66% +0.06%
==========================================
Files 1200 1201 +1
Lines 250326 250799 +473
Branches 26096 26192 +96
==========================================
+ Hits 171701 172199 +498
+ Misses 71809 71783 -26
- Partials 6816 6817 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Update Cumulative handling of nulls based on DataFrame documentation
michaelgsharp
approved these changes
May 8, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Math logic to filter out
nullinstead of treating it asdefault.Related Issue:
#6659